Draft
Conversation
bthirion
approved these changes
May 5, 2024
Member
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
When you're done with the pass, you can merge.
| FD = np.sum(np.abs(motion_diff[:, 0:3]) + 50 * np.abs(motion_diff[:, 3:]), | ||
| axis=1) | ||
| return FD | ||
| # %% |
Member
There was a problem hiding this comment.
You should skip 2 lines btw functions. LGTM otherwise.
| plt.xticks(np.arange(len(PTS)), [f"{sub}" for sub in PTS], rotation=45) | ||
| plt.suptitle(f'Framewise Displacement for {task}') | ||
|
|
||
| #plt.figure(figsize=(10, 7)) |
Member
There was a problem hiding this comment.
Don't keep commented lines in your scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the discussion, it was decided that the figure 4b on the revised version of the paper needed to go from using the FWER-corrected p-values for the mask to use FDR instead. This script does that.
This is the first of several commits, I intent to push the rest of the codes here too asap.