[FIX] Fix the data parser util#95
Open
pbarbarant wants to merge 1 commit intoindividual-brain-charting:masterfrom
Open
[FIX] Fix the data parser util#95pbarbarant wants to merge 1 commit intoindividual-brain-charting:masterfrom
pbarbarant wants to merge 1 commit intoindividual-brain-charting:masterfrom
Conversation
bthirion
reviewed
Sep 14, 2025
| acquisitions.append('') | ||
|
|
||
| # preprocessed bold images and corresponding motion parameters | ||
| if derivatives in [DERIVATIVES, THREE_MM]: |
Contributor
Author
There was a problem hiding this comment.
It might be a github visualization issue, I'm only removing the if statement
Member
There was a problem hiding this comment.
Actually, the point was to sckip that block whenever derivatives == SMOOTH_DERIVATIVES
bthirion
reviewed
Sep 16, 2025
| acquisitions.append('') | ||
|
|
||
| # preprocessed bold images and corresponding motion parameters | ||
| if derivatives in [DERIVATIVES, THREE_MM]: |
Member
There was a problem hiding this comment.
Actually, the point was to sckip that block whenever derivatives == SMOOTH_DERIVATIVES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes utils_data.data_parser by ensuring that we are actually using the derivatives path provided by the user