fix: stale hubCoins in transaction and unhandled batch flush promise#649
Open
saurabhhhcodes wants to merge 2 commits into
Open
fix: stale hubCoins in transaction and unhandled batch flush promise#649saurabhhhcodes wants to merge 2 commits into
saurabhhhcodes wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1: Stale hubCoins in streak transaction
In
AuthContext.jsxcheckAndUpdateStreak, the Firestore transaction readslatestDataviatransaction.get()but then usesdata.hubCoins(the stale snapshot data from the listener) instead oflatestData.hubCoins. This causes race conditions where concurrent updates to hubCoins are lost.Fix: Use
latestData.hubCoinsfrom the transaction read.Bug 2: Unhandled promise rejection in batch flush
In
FirestoreBatchOptimizer.add(),this.flush()was called withoutawaitor.catch(), causing unhandled promise rejections when the batch commit fails.Fix: Added
.catch()to handle the rejected promise gracefully.