Fix TypeInferenceMapper.map_floor_div with integral dtypes.#1000
Open
kaushikcfd wants to merge 3 commits intomainfrom
Open
Fix TypeInferenceMapper.map_floor_div with integral dtypes.#1000kaushikcfd wants to merge 3 commits intomainfrom
kaushikcfd wants to merge 3 commits intomainfrom
Conversation
kaushikcfd
force-pushed
the
type_inf_mapper_uints_floor_div
branch
from
b8124e1 to
8ee1b9f
Compare
kaushikcfd
force-pushed
the
type_inf_mapper_uints_floor_div
branch
from
8ee1b9f to
0ab87c4
Compare
inducer
reviewed
Mar 31, 2026
| else expr.numerator | ||
| ) | ||
| denom = ( | ||
| np.empty(0, dtype=d_dtype) |
Owner
There was a problem hiding this comment.
Isn't there a risk here of using a zero denominator in a carried-out calculation?
Comment on lines
+443
to
+444
| if not is_integer(expr.numerator) | ||
| else expr.numerator |
Owner
There was a problem hiding this comment.
Numpy no longer does value-dependent types AFAIK (as of 2.0), so IMO this if isn't necessary. Just use 1/1 unconditionally.
Collaborator
Author
There was a problem hiding this comment.
I don't think we can avoid the conditional.
>>> ary_u64 = np.empty(0, dtype=np.uint64)
>>> (ary_u64 // 2).dtype
dtype('uint64')
>>> (ary_u64 // np.empty(0, np.int32)).dtype # if we don't use the if.
dtype('float64')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #999.