Skip to content

Fixes for Ruff 0.15.8 #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 2 commits into from
Mar 27, 2026
+14 −24
Merged

Fixes for Ruff 0.15.8 #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6ff348
Fixes for Ruff 0.15.8
kaushikcfd Mar 27, 2026
f909769
Update basedpyright/baseline.json.
kaushikcfd Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .basedpyright/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6740,32 +6740,32 @@
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 41,
"endColumn": 42,
"startColumn": 52,
"endColumn": 53,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 41,
"endColumn": 42,
"startColumn": 46,
"endColumn": 47,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 41,
"endColumn": 42,
"startColumn": 52,
"endColumn": 53,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 41,
"endColumn": 42,
"startColumn": 46,
"endColumn": 47,
"lineCount": 1
}
},
Expand Down
18 changes: 6 additions & 12 deletions loopy/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,6 @@ def ensure_depends_only_on_arguments(

for tv in kernel.temporary_variables.values():
what = f"offset of temporary '{tv.name}'"
if tv.offset is None:
pass
if tv.offset is auto:
pass
elif isinstance(tv.offset, (int, np.integer, ExpressionNode, str)):
Expand Down Expand Up @@ -1469,22 +1467,18 @@ def _check_for_unused_hw_axes_in_kernel_chunk(
if group_axes != group_axes_used:
raise LoopyError(
f"instruction '{insn.id}' does not use all group hw axes "
"(available: %s used: %s). "
f"(available: {','.join(str(i) for i in group_axes)} "
f"used: {','.join(str(i) for i in group_axes_used)}). "
"Calling loopy.add_inames_for_unused_hw_axes(...) "
"might help."
% (
",".join(str(i) for i in group_axes),
",".join(str(i) for i in group_axes_used)))
"might help.")

if local_axes != local_axes_used:
raise LoopyError(
f"instruction '{insn.id}' does not use all local hw axes "
"(available: %s used: %s). "
f"(available: {','.join(str(i) for i in local_axes)} "
f"used: {','.join(str(i) for i in local_axes_used)}). "
"Calling loopy.add_inames_for_unused_hw_axes(...) "
"might help."
% (
",".join(str(i) for i in local_axes),
",".join(str(i) for i in local_axes_used)))
"might help.")

elif isinstance(sched_item, (Barrier, EnterLoop, LeaveLoop)):
i += 1
Expand Down
4 changes: 0 additions & 4 deletions loopy/preprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,6 @@ def make_args_for_offsets_and_strides(kernel: LoopKernel) -> LoopKernel:
for arg in kernel.args:
if isinstance(arg, ArrayArg) and not arg._separation_info:
what = f"offset for argument '{arg.name}'"
if arg.offset is None:
pass
if arg.offset is auto:
offset_name = vng(arg.name+"_offset")
additional_args.append(ValueArg(
Expand Down Expand Up @@ -300,8 +298,6 @@ def zero_offsets_and_strides(kernel: LoopKernel) -> LoopKernel:
new_args = []
for arg in kernel.args:
if isinstance(arg, ArrayArg):
if arg.offset is None:
pass
if arg.offset is auto:
made_changes = True
arg = arg.copy(offset=0)
Expand Down
Loading