Fix Reduction.inames_set to return frozenset instead of mutable set#998
Merged
Fix Reduction.inames_set to return frozenset instead of mutable set#998
Reduction.inames_set to return frozenset instead of mutable set#998Conversation
Agent-Logs-Url: https://github.com/inducer/loopy/sessions/ec0280a0-1f38-4798-a099-618bd80e5621 Co-authored-by: inducer <352067+inducer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix lp.Reduction.inames_set to return frozenset
Fix Mar 29, 2026
Reduction.inames_set to return frozenset instead of mutable set
There was a problem hiding this comment.
Pull request overview
This PR fixes a mutability hazard in Reduction.inames_set by ensuring the cached value cannot be modified by callers, preventing silent corruption of subsequent accesses.
Changes:
- Change
Reduction.inames_set(acached_property) to returnfrozenset[str]instead ofset[str].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduction.inames_setwas acached_propertyreturning a mutableset, allowing callers to silently corrupt the cached value and affect all subsequent accesses.Change
Reduction.inames_setnow returnsfrozenset[str]instead ofset[str], making the cached value immutable. All existing call sites using set operations (&,-, etc.) are unaffected sincefrozensetsupports them.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.