Conversation
inducer
force-pushed
the
kronrod
branch
5 times, most recently
from
30616c6 to
301c601
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Gauss–Kronrod quadrature support, including rule construction utilities, an adaptive integrator, and docs/type-checker updates.
Changes:
- Introduces
modepy.quadrature.kronrodimplementing Kronrod/Gauss rule construction and an adaptivequadgk. - Adds Sphinx documentation entry for the new quadrature module.
- Updates pytest configuration and extends the basedpyright baseline for the new module.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
pyproject.toml |
Adds pytest discovery configuration (currently overly broad). |
modepy/quadrature/kronrod.py |
New Kronrod/Gauss rule construction + adaptive integrator + inline tests. |
doc/quadrature.rst |
Documents the new Gauss–Kronrod module via automodule. |
.basedpyright/baseline.json |
Adds many new ignores for pyright issues in the new module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @ShawnL00