Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where calling set_arg with a None argument would fail due to missing Python binding configuration. The fix enables the Python binding to accept None values, which the C++ implementation already handles correctly by setting a null kernel argument.
Changes:
- Added
.none(true)flag to theset_argmethod'sargparameter in the Python binding - Added a regression test to verify
set_argacceptsNonewithout raising an exception
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/wrap_cl_part_2.cpp | Modified set_arg binding to allow None values by adding .none(true) to the arg parameter |
| test/test_wrapper.py | Added regression test test_set_arg_none to verify set_arg accepts None argument |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-897