Skip to content

[RFC] EqualityComparer: use data for DataWrapper comparison #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
matthiasdiener wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[RFC] EqualityComparer: use data for DataWrapper comparison #546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pytato/equality.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,10 @@ def map_size_param(self, expr1: SizeParam, expr2: Any) -> bool:
)

def map_data_wrapper(self, expr1: DataWrapper, expr2: Any) -> bool:
return expr1 is expr2
import numpy as np
return (expr1.__class__ is expr2.__class__
and np.array_equal(expr1.data.get(), expr2.data.get())
)

def map_index_lambda(self, expr1: IndexLambda, expr2: Any) -> bool:
return (expr1.__class__ is expr2.__class__
Expand Down