Skip to content

Fix CachedMapper's rec/rec_function_definition typing#654

Open
majosm wants to merge 2 commits intoinducer:mainfrom
majosm:fix-cached-mapper-rec-typing
Open

Fix CachedMapper's rec/rec_function_definition typing#654
majosm wants to merge 2 commits intoinducer:mainfrom
majosm:fix-cached-mapper-rec-typing

Conversation

@majosm
Copy link
Copy Markdown
Collaborator

@majosm majosm commented Mar 26, 2026

Eliminates the basedpyright warnings that appear every time a cached mapper overrides rec/rec_function_definition, e.g.:

pytato/transform/__init__.py:529:44 - warning: Type of "rec" is partially unknown
  Type of "rec" is "(self: Mapper[Unknown, Unknown, ...], expr: Array | AbstractResultWithNamedArrays, ...) -> Unknown" (reportUnknownMemberType)
pytato/transform/__init__.py:529:44 - warning: Argument type is unknown
  Argument corresponds to parameter "result" in function "_cache_add" (reportUnknownArgumentType)
pytato/transform/__init__.py:542:25 - warning: Type of "rec_function_definition" is partially unknown
  Type of "rec_function_definition" is "(self: Mapper[Unknown, Unknown, ...], expr: FunctionDefinition, ...) -> Unknown" (reportUnknownMemberType)
pytato/transform/__init__.py:542:25 - warning: Argument type is unknown
  Argument corresponds to parameter "result" in function "_function_cache_add" (reportUnknownArgumentType)

by using super(CachedMapper, self) instead of Mapper.

Testing out Claude for type checking troubleshooting. 🙂 cc @lukeolson

@majosm majosm marked this pull request as ready for review March 26, 2026 16:12
@majosm majosm requested a review from inducer March 26, 2026 16:17
@majosm majosm force-pushed the fix-cached-mapper-rec-typing branch from 953e246 to 646a66b Compare March 26, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant