Skip to content

Allow extra args/kwargs in CombineMapper #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 2 commits into from
Mar 26, 2026
Merged

Allow extra args/kwargs in CombineMapper #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fcc46c
update baseline
majosm Mar 26, 2026
3ca09f3
allow extra arguments in CombineMapper
majosm Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 0 additions & 72 deletions .basedpyright/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6201,14 +6201,6 @@
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 13,
"endColumn": 44,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
Expand Down Expand Up @@ -6929,22 +6921,6 @@
"lineCount": 1
}
},
{
"code": "reportImplicitOverride",
"range": {
"startColumn": 8,
"endColumn": 21,
"lineCount": 1
}
},
{
"code": "reportImplicitOverride",
"range": {
"startColumn": 8,
"endColumn": 41,
"lineCount": 1
}
},
{
"code": "reportUnusedParameter",
"range": {
Expand All @@ -6961,22 +6937,6 @@
"lineCount": 1
}
},
{
"code": "reportPrivateUsage",
"range": {
"startColumn": 29,
"endColumn": 39,
"lineCount": 1
}
},
{
"code": "reportUnusedParameter",
"range": {
"startColumn": 38,
"endColumn": 42,
"lineCount": 1
}
},
{
"code": "reportUnusedParameter",
"range": {
Expand All @@ -6985,14 +6945,6 @@
"lineCount": 1
}
},
{
"code": "reportPrivateUsage",
"range": {
"startColumn": 29,
"endColumn": 39,
"lineCount": 1
}
},
{
"code": "reportImplicitOverride",
"range": {
Expand Down Expand Up @@ -10523,22 +10475,6 @@
"lineCount": 1
}
},
{
"code": "reportArgumentType",
"range": {
"startColumn": 62,
"endColumn": 79,
"lineCount": 1
}
},
{
"code": "reportArgumentType",
"range": {
"startColumn": 62,
"endColumn": 79,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
Expand All @@ -10554,14 +10490,6 @@
"endColumn": 51,
"lineCount": 1
}
},
{
"code": "reportArgumentType",
"range": {
"startColumn": 62,
"endColumn": 79,
"lineCount": 1
}
}
],
"./test/test_pytato.py": [
Expand Down
2 changes: 1 addition & 1 deletion pytato/analysis/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ def get_num_call_sites(outputs: ArrayOrNames) -> int:

# {{{ TagCountMapper

class TagCountMapper(CombineMapper[int, Never]):
class TagCountMapper(CombineMapper[int, Never, []]):
"""
Returns the number of nodes in a DAG that are tagged with all the tag types in
*tag_types*.
Expand Down
2 changes: 1 addition & 1 deletion pytato/distributed/partition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ def _recv_to_comm_id(


class _LocalSendRecvDepGatherer(
CombineMapper[FrozenOrderedSet[CommunicationOpIdentifier], Never]):
CombineMapper[FrozenOrderedSet[CommunicationOpIdentifier], Never, []]):
def __init__(self, local_rank: int) -> None:
super().__init__()
self.local_comm_ids_to_needed_comm_ids: \
Expand Down
3 changes: 2 additions & 1 deletion pytato/target/loopy/codegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,8 @@ def map_call(self, expr: Call, state: CodeGenState) -> None:
}


class ReductionCollector(scalar_expr.CombineMapper[frozenset[scalar_expr.Reduce], []]):
class ReductionCollector(
scalar_expr.CombineMapper[frozenset[scalar_expr.Reduce], []]):
"""
Constructs a :class:`frozenset` containing all instances of
:class:`pytato.scalar_expr.Reduce` found in a scalar expression.
Expand Down
Loading
Loading