Conversation
alexfikl
approved these changes
Apr 1, 2026
Collaborator
alexfikl
left a comment
alexfikl
left a comment
There was a problem hiding this comment.
Looks great, no further comments 😁
There was a problem hiding this comment.
Pull request overview
This PR follows up on the recent QBX refinement-mode API work by renaming the “complain” mode to a more explicit enum member name, updating refinement error paths accordingly, and adjusting Sphinx configuration for the NOT_PROVIDED sentinel type reference.
Changes:
- Rename
QBXRefinementMode.COMPLAINtoQBXRefinementMode.ERROR_ON_REFINEMENTand update stage-1/stage-2 refinement checks and error messages. - Remove
QBXRefinementMode/QBXRefinementNeededErrorfrompytential.qbxmodule-level autodoc listing. - Update Sphinx
nitpick_ignore_regexto ignoreNOT_PROVIDEDinstead of_not_provided.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pytential/qbx/refinement.py | Renames the enum mode and updates the error-on-refinement checks/messages and docstring. |
| pytential/qbx/init.py | Adjusts the pytential.qbx module docstring autodoc entries (removes refinement types). |
| doc/conf.py | Updates Sphinx nitpick ignore regex to match NOT_PROVIDED. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h/t @alexfikl
x-ref
#310 (review)