Skip to content

build: Verify the PHARs signature before using them #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theofidry wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: Verify the PHARs signature before using them #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,17 @@ PHP=$(shell which php)
# Default parallelism
JOBS=$(shell nproc)

TOOL_DOWNLOAD_DIR := var/download
TOOL_DIR := var/tools

# PHP CS Fixer
PHP_CS_FIXER=./.tools/php-cs-fixer
PHP_CS_FIXER_URL="https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v3.35.1/php-cs-fixer.phar"
PHP_CS_FIXER := $(TOOL_DIR)/php-cs-fixer.phar
PHP_CS_FIXER_VERSION := .tools/php-cs-fixer-version
PHP_CS_FIXER_GPG_KEY := E82B2FB314E9906E
TMP_PHP_CS_FIXER := $(TOOL_DOWNLOAD_DIR)/$(shell basename $(PHP_CS_FIXER))
TMP_PHP_CS_FIXER_SIGNATURE := $(TMP_PHP_CS_FIXER).asc
PHP_CS_FIXER_URL := "https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/$(shell cat $(PHP_CS_FIXER_VERSION))/php-cs-fixer.phar"
PHP_CS_FIXER_URL_SIGNATURE := "https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/$(shell cat $(PHP_CS_FIXER_VERSION))/php-cs-fixer.phar.asc"

# PHPUnit
PHPUNIT=vendor/bin/phpunit
Expand Down Expand Up @@ -97,7 +105,26 @@ $(INFECTION): Makefile
chmod a+x $(INFECTION)
touch $@

$(PHP_CS_FIXER): Makefile
wget -q $(PHP_CS_FIXER_URL) --output-document=$(PHP_CS_FIXER)
chmod a+x $(PHP_CS_FIXER)
touch $@
$(PHP_CS_FIXER): $(PHP_CS_FIXER_VERSION)
$(MAKE) $(TMP_PHP_CS_FIXER)

mkdir -p $(TOOL_DOWNLOAD_DIR)
mv $(TMP_PHP_CS_FIXER) $@
touch -c $@

$(TMP_PHP_CS_FIXER): $(PHP_CS_FIXER_VERSION)
mkdir -p $(TOOL_DOWNLOAD_DIR)
wget --quiet $(PHP_CS_FIXER_URL) --output-document=$@
wget --quiet $(PHP_CS_FIXER_URL_SIGNATURE) --output-document=$(TMP_PHP_CS_FIXER_SIGNATURE)

@echo "Importing GPG key..."
@gpg --keyserver hkps://keys.openpgp.org --recv-keys $(PHP_CS_FIXER_GPG_KEY) >/dev/null 2>&1 || \
(echo "ERROR: Failed to import GPG key" && rm -f $@ $(TMP_PHP_CS_FIXER_SIGNATURE) && exit 1)
@echo "Verifying signature..."
@gpg --verify $(TMP_PHP_CS_FIXER_SIGNATURE) $@ >/dev/null 2>&1 || \
(echo "ERROR: Signature verification FAILED!" && rm -f $@ $(TMP_PHP_CS_FIXER_SIGNATURE) && exit 1)
@echo "✓ Signature verification passed"
rm -f $(TMP_PHP_CS_FIXER_SIGNATURE)

chmod a+x $@
PHP_CS_FIXER_IGNORE_ENV=1 $@ --version
Loading