Skip to content

**Project 1 Review Pull** _-AKK_#1

Open
kestler01 wants to merge 1 commit intoinfinitelyann:mainfrom
kestler01:project1Review
Open

**Project 1 Review Pull** _-AKK_#1
kestler01 wants to merge 1 commit intoinfinitelyann:mainfrom
kestler01:project1Review

Conversation

@kestler01
Copy link


do not merge merge this code

This is for you to look over and allows us to give direct feedback on your code in addition to a spreadsheet of more quantified grades

below is a brief summary, if you compare changes you will see any comments I made in your code highlighted in each file


Glows: ⭐️

  • excellent game demo and presentation
  • good use of async await and using a third party api !
  • thoroughly planned and followed through to completion, only polish left
  • implemented complex game logic in a very short amount of time and delivered a playable mvp !

Grows: 🌱

  • code organization can be improved, proper indentation and grouping will help your development process in the future and increase legibility
  • add comments to your code !
  • avoid duplicate files! you have 2 app.js, remove 1

Congratulations on a job very well done, keep up the great work Stephanie ! 😁

---

 **_do not merge merge this code_**

This is for you to look over and allows us to give direct feedback on your code in addition to a spreadsheet of more quantified grades

below is a brief summary, if you compare changes you will see any comments I made in your code highlighted in each file

---

**Glows:** ⭐️
- excellent game demo and presentation
- good use of async await and using a third party api !
- thoroughly planned and followed through to completion, only polish left
- implemented complex game logic in a very short amount of time and  delivered a playable mvp !

---

**Grows:** 🌱
- code organization can be improved, proper indentation and grouping will help your development process in the future and increase legibility
- add comments to your code !

---

Congratulations on a job very well done, keep up the great work Stephanie ! 😁
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant