Skip to content

Project 3 Review Pull _-AKK-_ #38

Open
kestler01 wants to merge 1 commit intoinfinitelyann:mainfrom
kestler01:project3Review
Open

Project 3 Review Pull _-AKK-_ #38
kestler01 wants to merge 1 commit intoinfinitelyann:mainfrom
kestler01:project3Review

Conversation

@kestler01
Copy link

do not merge merge this code

This is for you to look over and allows us to give direct feedback on your code in addition to a spreadsheet of more quantified grades

below is a brief summary, if you compare changes you will see any comments I made in your code highlighted in each file


Glows: ⭐️

  • excellent app demo and presentation
  • thoroughly planned and followed through to completion
  • Very creative app with lots of extra features, truly hit V2+

Grows: 🌱

  • Be consistent, thinking of white space and indentation here
  • change the name and description in the package.json ( not commented because json)
  • Be better about indentation
  • revisit some comments about a more 'react' esc approach to you code (returns, when components get to big, when to use fragments, etc)
    -needs many more comments, make them meaningful

Nits: 🥢

  • consistency across different coders could be improved : every one has there own voice but we should learn to set and follow guide-lines. Particularly thinking of the white space and use of short vs long hand arrow functions in same use cases
  • more descriptive comments and more of them

Congratulations on a job very well done Tune Heads, great work ! 😁

see pull for summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant