Refactor file structure#1
Refactor file structure#1lishaduck wants to merge 29 commits intoinfinityJKA:mainfrom lishaduck:lishaduck-patch-1
Conversation
| - package-ecosystem: "pip" # See documentation for possible values | ||
| directory: "/" # Location of package manifests | ||
| schedule: | ||
| interval: "daily" |
| #save.dat | ||
| #autosave.dat |
There was a problem hiding this comment.
| #save.dat | |
| #autosave.dat | |
| save.dat | |
| autosave.dat |
| | Key | Mapping | | ||
| | ---------- | --------------- | | ||
| | 1 | SAVE | | ||
| | 2 | TOGGLE SIDESTEP | | ||
| | 3 | STAT | | ||
| | 4 | KEY ITEMS | | ||
| | q | A | | ||
| | e | B | | ||
| | w | UP | | ||
| | r | EQUIP | | ||
| | t | PARTY | | ||
| | a | LEFT | | ||
| | s | DOWN | | ||
| | d | RIGHT | | ||
| | f | ITEM | | ||
| | g | TALK | | ||
| | arrow keys | movement | | ||
| | space key | for TALK | |
There was a problem hiding this comment.
Converted the list to a table
| @@ -0,0 +1,4 @@ | |||
| """Bipole V! A game. | |||
|
|
|||
| TODO: Ought BipoleV.py to be renamed to __init__.py, and replace this? | |||
pyproject.toml
Outdated
| numpy = "^1.23.5" | ||
| pillow = "^9.3.0" | ||
| python = "^3.10" |
There was a problem hiding this comment.
Dependencies for the project.
| @@ -0,0 +1,33 @@ | |||
| [tool.poetry] | |||
| authors = ["InfinityJKA <jkajustin@gmail.com>"] | |||
|
|
||
| from PIL import Image, ImageTk | ||
|
|
||
| current_directory: Path = Path(os.path.realpath(__file__)).parent |
There was a problem hiding this comment.
This is a better way to get the file's location, @infinityJKA.
| file_contents = open( | ||
| current_directory | ||
| / "dialogue" | ||
| / maps.current_location[4] | ||
| / (input_file + ".txt"), | ||
| encoding="UTF-8", | ||
| ) |
There was a problem hiding this comment.
Use the '/' operator to append strings to a path, @infinityJKA.
Oh, and when opening in text ("t") mode, always specify an encoding.
|
What did you use to build the output folder, @infinityJKA? |
|
I think I used auto-py-to-exe
…On Mon, Dec 19, 2022 at 10:11 AM Eli ***@***.***> wrote:
What did you use to build the output folder, @infinityJKA
<https://github.com/infinityJKA>?
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALNZ2I5JRV47VOQ664E7OFLWOCCLXANCNFSM6AAAAAATA6BOK4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I tried it, and it seemed to work. However, I'm on a managed mac, so I'm not sure. It wouldn't let me run it.
|
I think packaging works now, @infinityJKA. The only thing would be uploading the build artifacts to releases. I'd think there's a way to automate it, but I don't see one. |
auto-py-to-exe is a thin *graphical* wrapper over pyinstaller. However, we aren't we aren't using npm and puppeteer, so we need to use pyinstaller ourselves.
|
Packaging should be fixed now, @infinityJKA. |
|
Should I break this into smaller PRs, 1 at a time, @infinityJKA? |
Idk, if you want |
|
I've decided that I'm too busy to update this, and it's useless in this condition, so I'm closing it. |
|
real |
|
I'm going to prune the repo at the very least now that I can run it again. I'll try to be more conservative this time. |
|
@lishaduck should i be scared |
|
No. I'm going 1 commit @ a time |
|
Remember to commit responsibly! |
|
I've double checked, #2 still works fully on a managed mac w/py3.11.6! |
|
#3 is just docs, but I checked anyway, and it too works. |
2 participants
Also, fixes current_directory/cwd error, and rewrites the readme to use markdown, @infinityJKA. Reformats the code with black, sorts imports with isort, and manages dependencies with poetry. Adds a gitignore. Adds status checks.