Fix bug print bitmap on android#66
Open
TVMD wants to merge 1 commit intoinfoxicator:masterfrom
Open
Conversation
fix android build
harmit001
approved these changes
Apr 23, 2021
harmit001
left a comment
harmit001
left a comment
There was a problem hiding this comment.
this change works well. bitmap prints on Android as well.
|
Huge thanks to @TVMD for providing the fix. It was a huge help. Can folks in this project merge this bug fix? We tested and it worked like a charm. |
Author
|
Please merge this PR |
matthewparavati
added a commit
to Popmenu/react-native-star-prnt
that referenced
this pull request
Nov 24, 2021
- pulls in changes from the open PR infoxicator#66 on the forked react-native-star-prnt repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We has bug that printer does not print anything when using appendBitmap on Android devices.
This fix is mean for that bug. Basically, I change the way we generate bitmap from base64 string.