Release: v2.0.3

[Minitour]

This pull request refactors how the CLI determines when to perform version checks and display update notices. It introduces utility functions to more accurately detect the current subcommand and skip version checks for specific commands, and adds tests to ensure this logic is robust.

CLI Version Check Logic Improvements:

• Added cliSubcommandFromArgv and shouldSkipVersionCheck utilities to reliably identify the invoked subcommand and decide if the version check should be skipped (for upgrade and activity-ingest commands). [1] [2]
• Updated src/cli/index.ts to use these utilities, ensuring version checks are only performed when appropriate and update notices are not shown for commands that must produce machine-readable output. [1] [2]

Testing Enhancements:

• Added comprehensive tests for the new CLI subcommand detection and version check skipping logic in cli-subcommand.test.ts.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Fix CLI version-check gating for JSON-only subcommands

🐞 Bug fix 🧪 Tests 🕐 10-20 Minutes

AI Description

• Detect the invoked subcommand even when global flags come first.
• Skip background version checks and post-command update banners for JSON-only commands.
• Add unit tests covering argv parsing and skip rules.

Diagram

graph TD
  A["src/cli/index.ts"] --> B["cliSubcommandFromArgv(argv)"] --> C{"Skip version check?"} -->|"no"| D["checkForUpdates()"] --> E{"Has update?"} -->|"yes"| F["Print update notice"]
  C -->|"yes"| G["Run command only (stdout JSON-safe)"]
  E -->|"no"| G

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Use Commander parsing to resolve the subcommand

• ➕ Leverages the CLI framework’s understanding of commands/args (less bespoke argv logic).
• ➕ Potentially more robust if global options or subcommands evolve.
• ➖ Harder to do early because update-check is started before full command parsing/dispatch.
• ➖ May require refactoring command registration/execution order.

2. Always emit update notices to stderr (never stdout)

• ➕ Guarantees machine-readable stdout for all commands without per-command allowlists.
• ➕ Simplifies gating logic (version check can still run).
• ➖ Behavior change for users/scripts expecting notices on stdout.
• ➖ Some environments may not surface stderr by default (reduced visibility).

3. Config-driven suppression (env var / config file) for hook contexts

• ➕ Decouples behavior from subcommand names; hooks can opt-out explicitly.
• ➕ Avoids maintaining a growing list of special-case commands.
• ➖ Requires external coordination/documentation and changes in hook invocations.
• ➖ Still needs a default policy for typical users.

Recommendation: The PR’s approach (early argv-based subcommand detection + explicit skip list) is a pragmatic fix because it runs before command execution and directly protects JSON-only stdout for known hook subcommands. If more machine-readable commands appear, consider moving notices to stderr to avoid accumulating skip rules.

Files changed (3) +60 / -3

Bug fix (1) +11 / -3

index.tsGate update checks/notices based on parsed subcommand +11/-3

Gate update checks/notices based on parsed subcommand

• Replaces a hard-coded 'process.argv[2] === 'upgrade'' check with utilities that derive the first non-flag token as the subcommand. Skips starting 'checkForUpdates()' and suppresses the post-command update banner when the subcommand is 'upgrade' or 'activity-ingest' to keep stdout strictly machine-readable.

src/cli/index.ts

Refactor (1) +13 / -0

cli-subcommand.tsIntroduce CLI subcommand and version-check gating utilities +13/-0

Introduce CLI subcommand and version-check gating utilities

• Adds 'cliSubcommandFromArgv()' to find the first non-option token after the runtime/script args. Adds 'shouldSkipVersionCheck()' to centralize the allowlist of subcommands that must not append human-readable output after execution.

src/cli/utils/cli-subcommand.ts

Tests (1) +36 / -0

cli-subcommand.test.tsAdd tests for argv subcommand detection and skip rules +36/-0

Add tests for argv subcommand detection and skip rules

• Introduces Bun tests validating that the subcommand resolver ignores leading global options and that version-check skipping applies only to 'upgrade' and 'activity-ingest'. Covers undefined/other subcommand cases to prevent regressions.

src/cli/utils/tests/cli-subcommand.test.ts

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.