Skip to content

Refactor telemetry_chargeback to use scenario_result dictionary#376

Open
myadla wants to merge 5 commits into
masterfrom
myadla_enhance_ck
Open

Refactor telemetry_chargeback to use scenario_result dictionary#376
myadla wants to merge 5 commits into
masterfrom
myadla_enhance_ck

Conversation

@myadla
Copy link
Copy Markdown
Contributor

@myadla myadla commented May 5, 2026

Depends-On: #369

These are the enhancements as per Jira https://redhat.atlassian.net/browse/OSPRH-27861 for PR#335

  1. Replaces file-suffix variables with a scenario_result dictionary that carries metadata (file_name, num_values, total_rate, summaries) through the pipeline via set_fact
  2. Replaces file-based diff comparisons with direct dict-value assertions

myadla added 2 commits May 5, 2026 00:03
Bring in the full Loki data lifecycle testing workflow:
- Synthetic data generation with scenario configs
- Loki ingestion, flush, and retrieval tasks
- CloudKitty rating comparison
- Setup and cleanup tasks
Replace file-suffix variables with a scenario_result dictionary that
carries metadata (file_name, num_values, total_rate, summaries) through
the pipeline via set_fact. This addresses review feedback from PR #335
(OSPRH-27861) to avoid saving intermediate data to files and re-reading
them across tasks.

Changes:
- Remove 5 suffix variables from vars/main.yml
- Build scenario_result dict in gen_synth_loki_data.yml
- Update retrieve_loki_data.yml to use and enrich the dict
- Update loki_rate.yml to use dict and add CloudKitty ratings
- Replace file-diff comparison in run_test_scenarios.yml with
  direct dict-value assertions
- Update ingest_loki_data.yml to use dict for file path
- Update README.md to document the new dictionary structure
@centosinfra-prod-github-app
Copy link
Copy Markdown

Unable to freeze job graph: Unable to modify final job <Job noop explicit: None implied: None source: None#0> attribute parent=noop with variant <Job feature-verification-tests-noop explicit: None implied: {MatchAny:{ImpliedBranchMatcher:master}} source: infrawatch/feature-verification-tests/.zuul.yaml@master#139>

@myadla
Copy link
Copy Markdown
Contributor Author

myadla commented May 5, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

Unable to freeze job graph: Unable to modify final job <Job noop explicit: None implied: None source: None#0> attribute parent=noop with variant <Job feature-verification-tests-noop explicit: None implied: {MatchAny:{ImpliedBranchMatcher:master}} source: infrawatch/feature-verification-tests/.zuul.yaml@master#139>

@myadla
Copy link
Copy Markdown
Contributor Author

myadla commented May 5, 2026

PR addressing rdo/github-check failure: #369
Doing a Depends-On to get the changes tested

@myadla
Copy link
Copy Markdown
Contributor Author

myadla commented May 5, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/1dfa8435192345e3bd877e642b2b4198

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 37m 45s
functional-chargeback-tests-osp18 FAILURE in 1h 38m 20s
✔️ feature-verification-tests-noop SUCCESS in 1m 03s
✔️ functional-tests-osp18 SUCCESS in 2h 20m 59s

@myadla
Copy link
Copy Markdown
Contributor Author

myadla commented May 7, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/e669facf034c478ea31b6af8ae550b10

telemetry-openstack-meta-content-provider-master FAILURE in 12m 08s
⚠️ functional-chargeback-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master
✔️ feature-verification-tests-noop SUCCESS in 1m 05s
⚠️ functional-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@myadla
Copy link
Copy Markdown
Contributor Author

myadla commented May 11, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/3afa972d23854251a93d4dc1914bc4d6

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 12m 52s
functional-chargeback-tests-osp18 FAILURE in 1h 49m 22s
✔️ feature-verification-tests-noop SUCCESS in 1m 06s
functional-tests-osp18 FAILURE in 1h 55m 25s

@myadla
Copy link
Copy Markdown
Contributor Author

myadla commented May 11, 2026

OpenStackDataPlaneDeployment(EDPM) timed out. The telemetry_chargeback role didnot got a chance to run.
recheck

@myadla
Copy link
Copy Markdown
Contributor Author

myadla commented May 11, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/5bffc1357fce4764a77fb857426400c1

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 25m 04s
functional-chargeback-tests-osp18 FAILURE in 1h 42m 29s
✔️ feature-verification-tests-noop SUCCESS in 1m 05s
✔️ functional-tests-osp18 SUCCESS in 2h 08m 58s

myadla added 2 commits May 11, 2026 21:05
The Loki query {service="cloudkitty"} returns data from all scenarios,
causing count and rate mismatches when comparing per-scenario results.

Fix by adding a scenario-specific label to the Loki stream during data
generation (-s/--scenario flag), then filtering by it during retrieval.

Changes:
- gen_synth_loki_data.py: Add --scenario CLI argument that injects a
  scenario label into the loki_stream dict
- loki_data_templ.j2: Render all loki_stream keys dynamically instead
  of hardcoding only service
- gen_synth_loki_data.yml: Pass -s "{{ item }}" to the script
- retrieve_loki_data.yml: Query with scenario filter
@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/8fac1bfa13634825aaa3e2521c057a00

✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 49m 10s
functional-chargeback-tests-osp18 FAILURE in 2h 31m 38s
✔️ feature-verification-tests-noop SUCCESS in 1m 07s
✔️ functional-tests-osp18 SUCCESS in 2h 18m 40s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant