Skip to content

Conversation

@awildturtok
Copy link
Collaborator

experimentally enables SecondaryIds in editorv2

@awildturtok awildturtok requested a review from Kadrian as a code owner January 27, 2026 14:17
@awildturtok awildturtok force-pushed the feature/bye-bye-time-editor-v1 branch from 6613893 to 0071e9f Compare January 27, 2026 16:18
experimentally enables SecondaryIds in editorv2
@awildturtok awildturtok force-pushed the feature/bye-bye-time-editor-v1 branch from 0071e9f to 2f3fe62 Compare January 27, 2026 16:24
@awildturtok awildturtok requested a review from thoniTUB as a code owner January 28, 2026 16:51
Copy link
Collaborator

@thoniTUB thoniTUB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hast du auch schon diesen Shortcut Keybind entfernt?

});

it("Can open the form editor tab", () => {
cy.viewport(1440, 900) // Forms are pushed too far to the side otherwise
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vielleicht kannst du das auch gleich global setzten, ist glaube ich auch schon irgendwo gesetzt

const queryString = JSON.stringify(node.query);

return TIMEBASED_OPERATOR_TYPES.some((op) => queryString.indexOf(op) !== -1);
return false; //TODO implement for new time based query ops
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ist das jetzt erstmal fertig für diesen PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants