feat: add storage api #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
force-pushed
the
prestwich/storage-api
branch
from
7152b93 to
67c6c16
Compare
Evalir
reviewed
Jan 15, 2026
Member
Author
|
don't review this PR yet |
prestwich
force-pushed
the
prestwich/storage-api
branch
from
8edb0f6 to
bfab627
Compare
prestwich
changed the base branch from
graphite-base/64
to
prestwich/reth-1.10
prestwich
changed the base branch from
prestwich/reth-1.10
to
graphite-base/64
prestwich
force-pushed
the
graphite-base/64
branch
from
5108d7a to
4abc534
Compare
prestwich
force-pushed
the
prestwich/storage-api
branch
from
bfab627 to
1a9f59f
Compare
Evalir
requested changes
Jan 23, 2026
Comment on lines
+49
to
+57
| let _ = self.exact(range.start)?; | ||
| while let Some((key, _value)) = self.read_next()? { | ||
| if key.as_ref() >= range.end { | ||
| break; | ||
| } | ||
| self.delete_current()?; | ||
| } | ||
| Ok(()) | ||
| } |
Member
There was a problem hiding this comment.
isn't this loop ignoring the first element?
Member
Author
|
closing in favor of #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One day's work on re-architecting reth DB with a hot/cold model