Conversation
Deploying interwovenkit-testnet with
|
| Latest commit: |
452144a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ef507f5.interwovenkit-testnet.pages.dev |
| Branch Preview URL: | https://impv-animations-cleanup.interwovenkit-testnet.pages.dev |
Deploying interwovenkit with
|
| Latest commit: |
452144a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3e00f0e0.interwovenkit.pages.dev |
| Branch Preview URL: | https://impv-animations-cleanup.interwovenkit.pages.dev |
Deploying interwovenkit-staging with
|
| Latest commit: |
452144a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3dc208d7.interwovenkit-staging.pages.dev |
| Branch Preview URL: | https://impv-animations-cleanup.interwovenkit-staging.pages.dev |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis PR adds accessibility support for users who prefer reduced motion. It introduces the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~18 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Fix all issues with AI agents
In
`@packages/interwovenkit-react/src/pages/wallet/tabs/portfolio/AppchainPositionGroup.module.css`:
- Around line 119-123: The reduced-motion rule for .collapsibleContent is lower
specificity than the component's existing selector so it never applies; update
the media query to use the same composite selector as the collapsible component
(e.g., .collapsibleRoot .collapsibleContent) or otherwise match the original
selector used elsewhere so specificity is equal (refer to .collapsibleContent
and .collapsibleRoot) and keep animation: none inside that more specific
selector.
In
`@packages/interwovenkit-react/src/pages/wallet/tabs/portfolio/AssetGroup.module.css`:
- Around line 151-155: The reduced-motion media query is less specific than the
original rules because those use [data-state] attribute selectors; update the
media query to target the exact same selectors (including the [data-state="..."]
attribute variants) that style .collapsibleContent (e.g., replicate the
selectors that include [data-state] and .collapsibleContent) so the override has
equal specificity and animation: none takes effect; do not use global
!important—match the original attribute-including selectors inside the `@media`
(prefers-reduced-motion: reduce) block.
In
`@packages/interwovenkit-react/src/pages/wallet/tabs/portfolio/InitiaPositionGroup.module.css`:
- Around line 119-123: The reduced-motion media query selector is less specific
than the original rules so it doesn't override them; update the media query to
target the exact attribute-specific selectors used elsewhere (e.g.,
.collapsibleContent[data-state="open"] and
.collapsibleContent[data-state="closed"]) and set animation: none on those
selectors (or add the same [data-state] attribute to the media query selector)
so the reduced-motion preference actually disables the animations for
.collapsibleContent.
In
`@packages/interwovenkit-react/src/pages/wallet/tabs/portfolio/LiquiditySection.module.css`:
- Around line 225-228: The reduced-motion media query currently targets
.collapsibleContent but is less specific than the existing [data-state="open"] /
[data-state="closed"] animation rules, so update the media query to target those
data-state selectors directly (e.g. [data-state="open"] .collapsibleContent and
[data-state="closed"] .collapsibleContent) and set animation: none; (or
animation: none !important if you prefer) so the animations on
.collapsibleContent are reliably disabled when prefers-reduced-motion is set.
In
`@packages/interwovenkit-react/src/pages/wallet/tabs/portfolio/VipSection.module.css`:
- Around line 195-199: The reduced-motion media query is using
.collapsibleContent with lower specificity than the selector that sets the
animation, so the override won't apply; update the media query to use the exact
same selector (or match its specificity) that originally defines the animation
(for example, replicate the full selector used elsewhere like .<parentSelector>
.collapsibleContent or the modifier selector used when the animation is
declared) and set animation: none; there — ensure the selector inside `@media`
(prefers-reduced-motion: reduce) exactly matches the original animation rule (or
increase specificity by repeating the class) so the override takes effect.
tansawit
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 4
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Respect user's motion preferences across all animated components: - Add prefers-reduced-motion media queries to disable CSS animations - Use useReducedMotion hook for react-spring transitions - Reduce modal translateY for subtler animation
tansawit
force-pushed
the
impv/animations-cleanup
branch
from
4bf1441 to
a3f7477
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prefers-reduced-motionmedia queries to disable CSS animations when users prefer reduced motionuseReducedMotionhook from react-spring to make spring transitions immediateTest plan
Note
Cursor Bugbot is generating a summary for commit 4bf1441. Configure here.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.