Skip to content

feat: Add speaker component with Content Fragment support and update filters #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tusharmane-tm merged 1 commit into from
Feb 6, 2026
Merged

feat: Add speaker component with Content Fragment support and update filters #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions component-definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,21 @@
}
}
},
{
"title": "Speaker",
"id": "speaker",
"plugins": {
"xwalk": {
"page": {
"resourceType": "core/franklin/components/block/v1/block",
"template": {
"name": "Speaker",
"model": "speaker"
}
}
}
}
},
Comment on lines +299 to +313
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the new 'Speaker' component definition is functionally correct, it seems to duplicate the configuration found in the new file ue/models/blocks/_speaker.json. This can lead to maintenance issues if the two definitions diverge. If this duplication is not part of an automated build process, consider consolidating them into a single source of truth to improve maintainability.

{
"title": "Table",
"id": "table",
Expand Down
1 change: 1 addition & 0 deletions component-filters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"image",
"quote",
"search",
"speaker",
"tabs",
"table",
"text",
Expand Down
11 changes: 11 additions & 0 deletions component-models.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,17 @@
}
]
},
{
"id": "speaker",
"fields": [
{
"component": "aem-content",
"name": "fragmentPath",
"label": "Content Fragment Path",
"description": "Path to the Content Fragment containing speaker data"
}
]
},
Comment on lines +367 to +377
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new model for the 'speaker' component appears to be a duplicate of the model defined in ue/models/blocks/_speaker.json. Maintaining configuration in multiple places can be error-prone. If possible, it would be better to have a single source of truth for component models to avoid inconsistencies in the future.

{
"id": "table",
"fields": [
Expand Down