Skip to content

feat: Add speaker element template with dynamic properties #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tusharmane-tm merged 1 commit into from
Feb 6, 2026
Merged

feat: Add speaker element template with dynamic properties #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cf-template/speaker.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

<div class="speaker-elmeent" id="{{properties.elements.id.value}}">
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a typo in the class name speaker-elmeent. This should likely be speaker-element to be consistent and to ensure any associated styles are applied correctly.

Suggested change
<div class="speaker-elmeent" id="{{properties.elements.id.value}}">
<div class="speaker-element" id="{{properties.elements.id.value}}">

<div>
<picture>
<img src="{{properties.elements.image_ext.value}}" alt="{{properties.elements.title.value}}" title="{{properties.elements.title.value}}">
</picture>
Comment on lines +4 to +6
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The <picture> element is redundant here as it only contains an <img> tag without any <source> elements. It can be removed for simpler markup. Additionally, the title attribute on the <img> tag duplicates the alt attribute's content, which is not recommended as it can cause issues for screen reader users. It's best to remove the title attribute in this case.

        <img src="{{properties.elements.image_ext.value}}" alt="{{properties.elements.title.value}}">

<h1>{{properties.elements.title.value}}</h1>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using an <h1> for the speaker's name is not recommended as it can harm SEO and accessibility. Typically, a page should have only one <h1> for the main title. For components like this, it's better to use a lower-level heading (e.g., <h2>, <h3>) or a styled <p> tag to maintain a proper document outline.

        <h2>{{properties.elements.title.value}}</h2>

<p>{{properties.elements.jobTitle.value}}</p>
<p>{{properties.elements.companyName.value}}</p>
</div>
</div>