Stop starter-pack and other card descriptions from overflowing their…#359
Merged
Conversation
* fix: fit pack and UI card descriptions to ~2 lines
Long card descriptions overflowed their cards. Shorten the codebase-wiki
starter pack and the slash-command MirrorSource/Mirror block previews, and
line-clamp the description text on the starter-pack picker, slash-command
preview, Navigator launcher cards, and share-receive dialog so any long
description truncates cleanly. Add a registry test capping pack descriptions
to the picker two-line budget. Regenerate Lingui catalogs.
* test: cap slash-command preview descriptions at the line-clamp-3 budget
Mirrors the STARTER_PACKS 64-char budget test for the slash-command
PREVIEW_CONFIG descriptions (line-clamped to 3 lines in SlashCommandMenu).
Asserts each resolved preview.description from getComponentItems() is
<= 120 chars, with a guard against a false green if resolution stops
yielding strings. Addresses the review's consistency suggestion.
* fix: drop redundant owner/repo from the share-receive clone card
The clone-card description repeated the owner/repo that the dialog header
already shows in full (the Repository metadata row) and restated the card
title's action — and that interpolated value was the only thing that
overflowed for long repo names. Make it a short static line, parallel to
the local card ('Pick the folder where you've cloned it.'); line-clamp-2
stays as a backstop. Removes the now-unused shareOwner/shareRepo consts.
GitOrigin-RevId: 2f1ff5cf0220e6b6ffa6442920f2b7e3cccf1d3e
![inkeep-internal-ci[bot]](https://avatars.githubusercontent.com/u/123133689?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/28316078595). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop starter-pack and other card descriptions from overflowing their cards. The "Codebase wiki" starter pack and the slash-command MirrorSource / Mirror block previews had descriptions long enough to wrap to many lines and stretch their cards; those are now concise. The description text on the starter-pack picker, the slash-command block preview, the Navigator project-launcher cards, and the share-receive dialog is now line-clamped, so any long description truncates cleanly instead of distorting the layout.