-
Notifications
You must be signed in to change notification settings - Fork 5
Update edge-sdk publish_map to support format_version 2
#85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
b-Tomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take a close look at the protobuf binding types, and discuss the default value for formatVersion, given that it has the potential of being a breaking change.
publish_map to support formatVerionpublish_map to support formatVersion v2
publish_map to support formatVersion v2publish_map to support format_version 2
Description
This PR updates the Protobuf definitions to include the new Format Version field. Additionally, the robot.py class has been updated to support this new field and assign it a default value of 2 so maps wont get flipped by default
Note
Adds
formatVersionto map protobuf and updatesRobotSession.publish_mapto send formatVersion=2 by default; also introducesGpsFixMessageand pose offset fields, with tests updated accordingly.inorbit_pb2.py):MapMessage.formatVersion(int64).GpsFixMessage(ts, latitude, longitude, altitude, bearing, accuracy flags, accuracy_meters, frame_id).LocationAndPoseMessage.{offset_x, offset_y}andPoseMessageData.{offset_x, offset_y}.robot.py):RobotMapgainsformat_version(default2).publish_map(...)acceptsformat_version(default2) and_send_mapsetsMapMessage.formatVersion.formatVersion = 2.Written by Cursor Bugbot for commit b9d685e. This will update automatically on new commits. Configure here.