Skip to content

Conversation

@IrinaTerebiznik
Copy link
Contributor

@IrinaTerebiznik IrinaTerebiznik commented Dec 3, 2025

Description

This PR updates the Protobuf definitions to include the new Format Version field. Additionally, the robot.py class has been updated to support this new field and assign it a default value of 2 so maps wont get flipped by default


Note

Adds formatVersion to map protobuf and updates RobotSession.publish_map to send formatVersion=2 by default; also introduces GpsFixMessage and pose offset fields, with tests updated accordingly.

  • Protobuf (inorbit_pb2.py):
    • Add MapMessage.formatVersion (int64).
    • New message: GpsFixMessage (ts, latitude, longitude, altitude, bearing, accuracy flags, accuracy_meters, frame_id).
    • Extend pose messages with offsets: LocationAndPoseMessage.{offset_x, offset_y} and PoseMessageData.{offset_x, offset_y}.
    • Minor generated-code updates (options/encoding).
  • Edge SDK (robot.py):
    • RobotMap gains format_version (default 2).
    • publish_map(...) accepts format_version (default 2) and _send_map sets MapMessage.formatVersion.
  • Tests:
    • Update map publish assertions to include formatVersion = 2.

Written by Cursor Bugbot for commit b9d685e. This will update automatically on new commits. Configure here.

@IrinaTerebiznik IrinaTerebiznik self-assigned this Dec 3, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copy link
Member

@b-Tomas b-Tomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take a close look at the protobuf binding types, and discuss the default value for formatVersion, given that it has the potential of being a breaking change.

@b-Tomas b-Tomas changed the title Update edge-sdk publish_map to support formatVerion Update edge-sdk publish_map to support formatVersion v2 Dec 5, 2025
@b-Tomas b-Tomas changed the title Update edge-sdk publish_map to support formatVersion v2 Update edge-sdk publish_map to support format_version 2 Dec 15, 2025
@b-Tomas b-Tomas merged commit 5b25df2 into main Dec 15, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants