Skip to content

DEN-386 - Fix PdFieldValueForkPipe dropping None target fields. #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
M-EZZ wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DEN-386 - Fix PdFieldValueForkPipe dropping None target fields. #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions pemi/pipes/pd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,21 +175,28 @@ def __init__(self, field, forks, **kwargs):
)

def flow(self):
grouped = self.sources['main'].df.groupby(self.field)
work_df = self.sources['main'].df.copy()
grouped = work_df.groupby(self.field)

for fork in self.forks:
if fork in grouped.groups:
self.targets[fork].df = grouped.get_group(fork).copy()
else:
self.targets[fork].df = pd.DataFrame(columns=self.sources['main'].df.columns)
self.targets[fork].df = pd.DataFrame(columns=work_df.columns)

remainder = set(grouped.groups.keys()) - set(self.forks)
if len(remainder) > 0:
self.targets['remainder'].df = pd.concat(
[grouped.get_group(r) for r in remainder]
).sort_index()
else:
self.targets['remainder'].df = pd.DataFrame(columns=self.sources['main'].df.columns)
self.targets['remainder'].df = pd.DataFrame(columns=work_df.columns)

if None in work_df[self.field].unique():
self.targets['remainder'].df = pd.concat(
[self.targets['remainder'].df, work_df[work_df[self.field].isna()]]
).sort_index()


class PdLambdaPipe(pemi.Pipe):
'''
Expand Down
10 changes: 5 additions & 5 deletions tests/pipes/test_pd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,8 +549,8 @@ def pipe(self):
)

df = pd.DataFrame({
'target': ['create', 'update', 'update', 'else1', 'create', 'else2'],
'values': [1, 2, 3, 4, 5, 6]
'target': ['create', 'update', 'update', 'else1', 'create', 'else2', '', None],
'values': [1, 2, 3, 4, 5, 6, 7, 8]
})

pipe.sources['main'].df = df
Expand Down Expand Up @@ -592,9 +592,9 @@ def test_it_forks_data_to_update(self, pipe):

def test_it_puts_unknown_values_in_remainder(self, pipe):
expected_df = pd.DataFrame({
'target': ['else1', 'else2'],
'values': [4, 6]
}, index=[3, 5])
'target': ['else1', 'else2', '', None],
'values': [4, 6, 7, 8]
}, index=[3, 5, 6, 7])
actual_df = pipe.targets['remainder'].df
pt.assert_frame_equal(actual_df, expected_df)

Expand Down