Jnj templates scripts checks 1) change deci format#215
Closed
Jnj templates scripts checks 1) change deci format#215
Conversation
Updated remote repository reference for formatters. Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
…j_templates_scripts
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
…templates_scripts
Signed-off-by: David Muñoz Tord <david.munoztord@mailbox.org>
Contributor
Unit Tests Summary 1 files 274 suites 22m 43s ⏱️ For more details on these failures, see this check. Results for commit c923f1a. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit 17aa8fe ♻️ This comment has been updated with latest results. |
Contributor
|
can you set it to merge to jnj_templates_scripts |
Collaborator
Author
Yes that was the plan, just wanted to have the tests running on github actions. And also you might want to unsubscribe from it because I need to debug quite a lot of things by re-running the pipeline checks :/ But I will tag you whenever things are solid. |
…templates_scripts
…templates_scripts_1_change_deci_format
…eci_format' into jnj_templates_scripts_1_change_deci_format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here in #209
Since the Shiny reviewer is local-only, I’ve also added the diff-checker link so you can see the exact line-by-line rtf changes.
Summary of changes:
The Change: Changed the format of a calculation in one of the template (tsids01) from one decimal to two decimals.

The Impact: