Fix the setup for uploads in the CI tests#146
Merged
robocoder merged 1 commit intoinstaclick:masterfrom Jan 6, 2026
Merged
Conversation
Older selenium versions support a non-standard feature to upload a file to the runner, which is used by the Mink driver when available. Newer Selenium versions implementing the W3C protocol don't support this anymore. Attaching a file to a file input requires using a file path that already exists on the runner. this configures the Mink testsuite to properly share the fixtures with the docker image of the runner.
Contributor
Author
|
Please wait before merging this PR in case the CI is not green, to avoid having to do even more PR to reach such state (previous PRs attempting to reach a working state were merged even if they did not succeed yet) |
Contributor
Author
|
OK, apparently, this fixes the setup entirely. This PR is ready. |
aik099
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older selenium versions support a non-standard feature to upload a file to the runner, which is used by the Mink driver when available. Newer Selenium versions implementing the W3C protocol don't support this anymore. Attaching a file to a file input requires using a file path that already exists on the runner. this configures the Mink testsuite to properly share the fixtures with the docker image of the runner.