[Feature] - Ajoute de nouveaux filtres pour Synapse by Xusifob · Pull Request #42 · instamedsolutions/rpps_api

Xusifob · 2026-02-27T06:50:18Z

No description provided.

Copilot

Pull request overview

Ajoute de nouveaux filtres API Platform pour faciliter la consommation “Synapse” (filtrage CIM-11 sur la présence d’un code CIM-10, et exclusion de catégories d’allergènes), avec adaptations côté import/mapping CIM-11 et couverture de tests fonctionnels.

Changes:

Ajout du filtre withCim10 sur la ressource CIM-11 + test fonctionnel associé.
Ajout du filtre excluded_categories sur la ressource Allergen + test fonctionnel associé.
Ajustements import/mapping CIM-11 + quelques changements connexes (index RPPS, requête d’exclusion RPPS, config de pagination).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tests/Functional/Cim11sTest.php	Ajoute un test fonctionnel pour le filtre `withCim10`.
tests/Functional/AllergenTest.php	Ajoute un test fonctionnel pour le filtre `excluded_categories`.
src/Entity/RPPS.php	Ajoute un index composite (specialty, id_rpps).
src/Entity/Cim11.php	Expose la propriété de filtre `withCim10` via `Cim11Filter`.
src/Entity/CCAM.php	Change `paginationPartial` à `false`.
src/Entity/Allergen.php	Ajoute `excluded_categories` au filtre + change `paginationPartial` à `false`.
src/DataFixtures/LoadDCim11.php	Ajoute une maladie sans `cim10Code` pour tester `withCim10`.
src/Command/Cim11Import.php	Introduit `getCim10Code()` pour le mapping CIM-10 (avec logique de fallback).
src/ApiPlatform/Filter/RPPSFilter.php	Modifie l’implémentation de `excluded_rpps` (NOT EXISTS) + nouveaux imports.
src/ApiPlatform/Filter/Cim11Filter.php	Implémente le filtre `withCim10` (boolean) via `IS NOT NULL`.
src/ApiPlatform/Filter/AllergenFilter.php	Implémente le filtre `excluded_categories` via `NOT IN`.
mapping-cim-11.csv	Ajoute une ligne de mapping (SD82 → F32.9).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-27T06:56:46Z

tests/Functional/AllergenTest.php

+        // Verify that at least some allergens remain after exclusion
+        $this->assertEquals(0, count($data['hydra:member']), 'No more allergens available');


The inline comment says you want to verify that some allergens remain after excluding categories, but the assertion expects an empty result set. Given fixtures only include the excluded groups, either update the comment to match the expected empty set (or add fixtures/assertions that ensure at least one allergen remains).

Suggested change

// Verify that at least some allergens remain after exclusion

$this->assertEquals(0, count($data['hydra:member']), 'No more allergens available');

// Verify that no allergens remain after exclusion when only excluded groups exist in fixtures

$this->assertEquals(0, count($data['hydra:member']), 'All allergens should be excluded');

Copilot · 2026-02-27T06:56:47Z

src/ApiPlatform/Filter/RPPSFilter.php

 use App\Entity\Specialty;
 use Doctrine\DBAL\Platforms\MySQLPlatform;
 use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\ORM\Query\Expr\Join;


Doctrine\ORM\Query\Expr\Join is imported but not used anywhere in this file. Please remove the unused use to avoid dead imports and keep the file clean.

Suggested change

use Doctrine\ORM\Query\Expr\Join;

Copilot · 2026-02-27T06:56:47Z

src/Entity/CCAM.php

    ],
    paginationClientEnabled: true,
-    paginationPartial: true,
+    paginationPartial: false,


Setting paginationPartial: false is a behavioral and performance change (it re-enables full pagination counts). Most other API resources in this repo use paginationPartial: true (e.g. src/Entity/Cim11.php, src/Entity/City.php). Please confirm this is intentional for CCAM and add a brief rationale (or revert if not needed).

Suggested change

paginationPartial: false,

paginationPartial: true,

Copilot · 2026-02-27T06:56:47Z

src/Entity/Allergen.php

    ],
    paginationClientEnabled: true,
-    paginationPartial: true,
+    paginationPartial: false,


Setting paginationPartial: false is a behavioral and performance change (it re-enables full pagination counts). Most other API resources in this repo use paginationPartial: true (e.g. src/Entity/Cim11.php, src/Entity/City.php). Please confirm this is intentional for allergens and add a brief rationale (or revert if not needed).

Suggested change

paginationPartial: false,

paginationPartial: true,

Copilot · 2026-02-27T06:56:47Z

src/Command/Cim11Import.php

+        if ('SD82' === $code) {
+            dump($this->cim11Mapping[$code]);
+            exit;
+        }
+


getCim10Code() contains a hard-coded dump() + exit for code SD82. This will abort the import command in real usage and must be removed (or replaced with proper logging/handling) before merging.

Suggested change

if ('SD82' === $code) {

dump($this->cim11Mapping[$code]);

exit;

}

Copilot · 2026-02-27T06:56:48Z

src/Command/Cim11Import.php

+    private function getCim10Code(string $code): ?string
+    {
+        if ('SD82' === $code) {
+            dump($this->cim11Mapping[$code]);
+            exit;
+        }
+
+        if (isset($this->cim11Mapping[$code])) {
+            return $this->cim11Mapping[$code];
+        }
+
+        if (str_ends_with($code, '0')) {
+            $codeWithoutLastZero = substr($code, 0, -1);


The fallback mapping for codes ending with 0 uses substr($code, 0, -1), which turns CA00.0 into CA00.. The mapping CSV stores ICD-11 codes without the trailing dot (e.g. CA00), so this fallback will still miss and return null. Consider normalizing the code by removing a trailing .0 (and/or trimming a trailing .) before looking up $this->cim11Mapping.

Suggested change

private function getCim10Code(string $code): ?string

{

if ('SD82' === $code) {

dump($this->cim11Mapping[$code]);

exit;

}

if (isset($this->cim11Mapping[$code])) {

return $this->cim11Mapping[$code];

}

if (str_ends_with($code, '0')) {

$codeWithoutLastZero = substr($code, 0, -1);

private function normalizeIcd11Code(string $code): string

{

// Remove a trailing ".0" (e.g. "CA00.0" -> "CA00")

$code = preg_replace('/\.0$/', '', $code);

// Trim any remaining trailing dot (e.g. "CA00." -> "CA00")

return rtrim($code, '.');

}

private function getCim10Code(string $code): ?string

{

$normalizedCode = $this->normalizeIcd11Code($code);

if ('SD82' === $normalizedCode) {

dump($this->cim11Mapping[$normalizedCode]);

exit;

}

if (isset($this->cim11Mapping[$normalizedCode])) {

return $this->cim11Mapping[$normalizedCode];

}

if (str_ends_with($normalizedCode, '0')) {

$codeWithoutLastZero = substr($normalizedCode, 0, -1);

Copilot · 2026-02-27T06:56:48Z

tests/Functional/Cim11sTest.php

+        $this->assertResponseStatusCodeSame(Response::HTTP_OK);
+
+        // Should have more or equal items when not filtering
+        $this->assertGreaterThanOrEqual(count($data['hydra:member']), count($dataAll['hydra:member']));


The count comparison is reversed: when withCim10=false (no filtering), the collection should have more or equal items than the filtered withCim10=true result. The current assertion checks the opposite and will fail when the filter actually reduces results.

Xusifob added 5 commits February 27, 2026 07:24

fix

0943d19

fixes

d5d9d50

[Feature] - Ajoute des filtres sur les allergènes

668d1ad

[Bug] - Fix un bug sur l'import de la base Cim-11

ec3a03f

fixes

575f188

Copilot AI review requested due to automatic review settings February 27, 2026 06:50

Copilot started reviewing on behalf of Xusifob February 27, 2026 06:50 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] - Ajoute de nouveaux filtres pour Synapse#42

[Feature] - Ajoute de nouveaux filtres pour Synapse#42
Xusifob wants to merge 5 commits intostagingfrom
feature/allergens-filters

Xusifob commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// Verify that at least some allergens remain after exclusion
		$this->assertEquals(0, count($data['hydra:member']), 'No more allergens available');

-    private function getCim10Code(string $code): ?string
-    {
-        if ('SD82' === $code) {
-            dump($this->cim11Mapping[$code]);
-            exit;
-        }
-        if (isset($this->cim11Mapping[$code])) {
-            return $this->cim11Mapping[$code];
-        }
-        if (str_ends_with($code, '0')) {
-            $codeWithoutLastZero = substr($code, 0, -1);
+    private function normalizeIcd11Code(string $code): string
+    {
+        // Remove a trailing ".0" (e.g. "CA00.0" -> "CA00")
+        $code = preg_replace('/\.0$/', '', $code);
+        // Trim any remaining trailing dot (e.g. "CA00." -> "CA00")
+        return rtrim($code, '.');
+    }
+    private function getCim10Code(string $code): ?string
+    {
+        $normalizedCode = $this->normalizeIcd11Code($code);
+        if ('SD82' === $normalizedCode) {
+            dump($this->cim11Mapping[$normalizedCode]);
+            exit;
+        }
+        if (isset($this->cim11Mapping[$normalizedCode])) {
+            return $this->cim11Mapping[$normalizedCode];
+        }
+        if (str_ends_with($normalizedCode, '0')) {
+            $codeWithoutLastZero = substr($normalizedCode, 0, -1);

Conversation

Xusifob commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants