fix(scratchpad): properly handle scratchpad tags when minimizing#242
fix(scratchpad): properly handle scratchpad tags when minimizing#242paperbenni wants to merge 4 commits intomainfrom
Conversation
When a scratchpad window was minimized (hidden), its `issticky` flag and `tags` were not updated to the `SCRATCHPAD_MASK`. This caused the window to still be considered visible on the active tags and rendered in the titlebar as a grayed-out "minimized" window. Clicking it would then incorrectly trigger `title_drag_finish` showing it again. Additionally, this prevented instantwmctl commands like `scratchpad show` from working, since the scratchpad was still considered `issticky` (visible). This patch modifies `src/client/visibility.rs`'s `hide` function to intercept when a scratchpad is hidden, properly clearing `issticky` and setting its `tags` to `SCRATCHPAD_MASK`, ensuring the scratchpad correctly drops out of the titlebar and standard toggle commands work. Co-authored-by: paperbenni <15818888+paperbenni@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
@jules |
Wait, I need to commit the changes first. My apologies! I'll commit the changes right now. |
Co-authored-by: paperbenni <15818888+paperbenni@users.noreply.github.com>
|
@jules |
Co-authored-by: paperbenni <15818888+paperbenni@users.noreply.github.com>
|
@jules |
Co-authored-by: paperbenni <15818888+paperbenni@users.noreply.github.com>
1 participant
Fixed an issue where hidden/minimized scratchpad windows were still appearing in the titlebar, breaking their visibility state.
The root cause was that hiding a scratchpad didn't reset its
isstickyproperty andtagsback to theSCRATCHPAD_MASK. As a result, the scratchpad still intersected with the currently selected workspace's tags, leading to it being drawn in the active workspace's titlebar (and making CLI/keybind toggles believe the scratchpad was already visible).This explicitly updates
issticky = falseandtags = SCRATCHPAD_MASKinhide()when hiding a scratchpad window.PR created automatically by Jules for task 18076435464278680179 started by @paperbenni