Fixed bug that forced loading events and views from pre-defined folder#3
Open
hellomrbrown wants to merge 1 commit intointegrationmonitoring:masterfrom
Open
Fixed bug that forced loading events and views from pre-defined folder#3hellomrbrown wants to merge 1 commit intointegrationmonitoring:masterfrom
hellomrbrown wants to merge 1 commit intointegrationmonitoring:masterfrom
Conversation
…r even in cases when a proper external path was provided.
|
+1 |
dmoskvin77
approved these changes
Apr 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[english version below]
Из-за некорректной проверки, код, который загружает View/Event, всегда загружает его из self::VIEW_FILES_PATH / self::EVENTS_FILES_PATH - даже в случае, когда передаешь корректный externalPath.
Исправил проверку на empty.
Due to incorrect check of externalPath variable, Views and Events are loaded from self::vIEW_FILES_PATH and self::EVENTS_FILES_PATH even when externalPath is passed into the function and is not null.
I've fixed the bug and replaced the check with simple "empty", which does the thing just fine.