Draft
Conversation
Niederb
commented
Jan 26, 2023
| // TODO: improve error handling, using a mut status is not good design? | ||
| let mut status: OCallBridgeResult<()> = Ok(()); | ||
|
|
||
| let mut slice = signed_blocks_encoded; |
Contributor
Author
There was a problem hiding this comment.
This is the "trick": Create a mutable copy of the slice (as decode() needs it). Maybe this could be written nicer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not really to be merged as it is incomplete. I think it would be a nice, small refactoring though and should be applied to the other functions in the trait (and maybe other traits).