Draft
Conversation
Contributor
Author
|
Giving up on this PR, as this is very tokio and worker specific. I hoped to see the efficiency increase but it seems not to be so easy to switch. @clangenb Should I leave this PR open for now, or rather close it? The one thing I can offer is to rebase it once #1263 has been merged and give the (squashed) commits a sensible name. |
Contributor
|
If you don't mind, rebasing it would be great to have a grasp of the diff then I will gladly have a look at it. However, you don't need to fix the commits. Thanks a lot! |
haerdib
force-pushed
the
bh/test-jsonrpsee
branch
2 times, most recently
from
46e93e2 to
e2159ce
Compare
Contributor
Author
|
@clangenb PR is rebased. I hope this helps |
well well taplo fmt lets try again fix clippy
Contributor
|
I will be taking over this PR, will do a rebase, and see how stuck it is right now. Is that okay, @haerdib? |
Contributor
Author
|
Yes, of course, go ahead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1395
Switch from simple ws-client to jsonrpsee client