Conversation
* [local-setup] fix setup with two workers: avoid using the same data dirs. (#1358) * [ita_stf/test_genesis] remove reserved balance from state, as it doesn't exist anymore * [enclave-runtime/top_pool_execution] downgrade logs to trace * [state_handler] add debug and trace logs * add additional flags for the worker setup * [its-consensus-aura/block_importer] add some more logs * local setup add some more logging
|
I think the flaky M6 test might be mitigated by #1405 |
| where | ||
| ValidateerFetcher: ValidateerFetch + EnclaveOnChainOCallApi, | ||
| P: Pair, | ||
| P::Public: UncheckedFrom<[u8; 32]>, |
There was a problem hiding this comment.
Authorities as well are too generic IMO. We could use the same itp_types::AccountId type strictly
too much trait bound jungle here
|
|
||
| /// Checks if we are the first validateer to register on the parentchain. | ||
| fn we_are_primary_validateer( | ||
| fn we_are_primary_worker( |
There was a problem hiding this comment.
this logic has now changed to something more meaningful. Instead of testing if we are the first enclave to have ever registered on this chain ( which would allow only a single sidechain to ever exist) we now check shard_status and see if some other enclave than self has ever touched that shard
|
@clangenb there may be quite some additional cleanup left after this PR as a consequence, but I thought the PR is big enough already. |
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Cool, only some minor issues; otherwise this looks more straightforward than I expected it to be!
core-primitives/node-api/api-client-extensions/src/pallet_teerex.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: clangenb <37865735+clangenb@users.noreply.github.com>
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
One minor thing, otherwise it looks good to me now! Will approve.
3 participants
closes #1384
Merge this first:
done: