Provision light-client state in mu-ra; fix w2 startup#1398
Closed
clangenb wants to merge 10 commits intoszp/polkadot-v0.9.42from
Closed
Provision light-client state in mu-ra; fix w2 startup#1398clangenb wants to merge 10 commits intoszp/polkadot-v0.9.42from
clangenb wants to merge 10 commits intoszp/polkadot-v0.9.42from
Conversation
…ion import type.
…-production import type." This reverts commit c3c46fd.
…ms such that it can be shared across threads in an arc. [light-client] add constructor to `LightClientStateSealSync` fix light-client adjustments remove pending wip of sealing adjustements
clangenb
commented
Jul 31, 2023
| pub scheduled_change: Option<ScheduledChangeAtBlock<Block::Header>>, // Scheduled Authorities change as indicated in the header's digest. | ||
| } | ||
|
|
||
| impl<Block: BlockT> RelayState<Block> { |
Contributor
Author
There was a problem hiding this comment.
Todo to me: introduce separate datatype instead of implementing this on the RelayState itself, and do some testing
Comment on lines
+251
to
+253
| /// Light client db seal. | ||
| pub static GLOBAL_LIGHT_CLIENT_SEAL: ComponentContainer<EnclaveLightClientSeal> = | ||
| ComponentContainer::new("EnclaveLightClientSealSync"); |
Contributor
Author
There was a problem hiding this comment.
Had to introduce a separate component to access this in the tls-ra domain
Comment on lines
-38
to
-44
| where | ||
| ShieldingKeyRepository: AccessKey<KeyType = Rsa3072KeyPair> + MutateKey<Rsa3072KeyPair>, | ||
| StateKeyRepository: AccessKey<KeyType = Aes> + MutateKey<Aes>, | ||
| // Constraint StateT = StfState currently necessary because SgxExternalities Encode/Decode does not work. | ||
| // See https://github.com/integritee-network/sgx-runtime/issues/46. | ||
| StateHandler: HandleState<StateT = StfState>, | ||
| { |
Contributor
Author
There was a problem hiding this comment.
unnecessary type constraints on the type definition
Contributor
Author
|
I can't explain currently, why I see the following erros in the failing integration tests: |
Contributor
This sometimes happens, because we are really pushing those machines when running the tests in parallel, and we (@mosonyi and I) suspect that the |
Contributor
Author
|
Alright, thanks a lot! 👍 |
Contributor
Author
|
Rebased on master and merge into master here #1399 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation should actually be independent of the polkadot-v0.9.42 update, I will also rebase this branch on master and file a standalone pr.