Enable ACPI firmware node path in MediaCtlConfig#28
Open
changchingyew wants to merge 7 commits intointel:mainfrom
Open
Enable ACPI firmware node path in MediaCtlConfig#28changchingyew wants to merge 7 commits intointel:mainfrom
changchingyew wants to merge 7 commits intointel:mainfrom
Conversation
The v4l2 entity name includes i2c adaptor number that is
dynamically allocated so it's hard to configured statically
in json file
Use ACPI firmware_node path ,i.e. \\_SB_.PC00.DES0 as configured
in json file as below
{
- "name": "max96724 1-0027", "sinkPad": 0, "sinkStream": 0, "srcPad": 4,
+ "acpiName": "\\_SB_.PC00.DES0", "sinkPad": 0, "sinkStream": 0, "srcPad": 4,
"srcStream": 0, "flag": 1
},
Signed-off-by: Yew, Chang Ching <chang.ching.yew@intel.com>
Signed-off-by: Yew, Chang Ching <chang.ching.yew@intel.com>
Signed-off-by: Yew, Chang Ching <chang.ching.yew@intel.com>
123456987789
suggested changes
Nov 19, 2025
123456987789
left a comment
123456987789
left a comment
There was a problem hiding this comment.
I think you just need to add acpiName to entity and transfer acpi name to entity name.
Sensor name is just a configuration name, not related with entity.
Signed-off-by: Yew, Chang Ching <chang.ching.yew@intel.com>
Signed-off-by: Yew, Chang Ching <chang.ching.yew@intel.com>
Signed-off-by: Yew, Chang Ching <chang.ching.yew@intel.com>
Signed-off-by: Yew, Chang Ching <chang.ching.yew@intel.com>
123456987789
approved these changes
Dec 9, 2025
123456987789
approved these changes
Dec 9, 2025
Author
|
Hi @qingwuzh, @123456987789 has approved this PR and would like your review on this PR too. Thanks |
qingwuzh
reviewed
Dec 10, 2025
Author
|
Hi @daxingli, need your approval for this PR. Thanks |
123456987789
suggested changes
Feb 3, 2026
| } | ||
| if (ele.isMember("acpiName")) { | ||
| route.entityName = mMediaCtl->acpiName2EntityName(ele["acpiName"].asString()); | ||
| if (mMediaCtl != nullptr) { |
There was a problem hiding this comment.
Why do you check mMediaCtl?
Check again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.