Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Tests for vec/marray math#1002

Merged
bader merged 25 commits intointel:intelfrom
JackAKirk:math_marray_tests
Dec 2, 2022
Merged

[SYCL] Tests for vec/marray math#1002
bader merged 25 commits intointel:intelfrom
JackAKirk:math_marray_tests

Conversation

@JackAKirk
Copy link

@JackAKirk JackAKirk commented Apr 21, 2022 •
edited
Loading

Tests for marray/vec SYCL math functions from: intel/llvm#6038

Signed-off-by: jack.kirk jack.kirk@codeplay.com

@JackAKirk JackAKirk mentioned this pull request Apr 21, 2022
Merged
@JackAKirk JackAKirk changed the title tests for vec/marray math [SYCL] tests for vec/marray math Apr 26, 2022
@JackAKirk JackAKirk changed the title [SYCL] tests for vec/marray math [SYCL] Tests for vec/marray math Apr 26, 2022
@JackAKirk JackAKirk marked this pull request as ready for review April 26, 2022 10:56
@JackAKirk JackAKirk requested a review from a team as a code owner April 26, 2022 10:56
@JackAKirk JackAKirk requested a review from steffenlarsen April 26, 2022 10:56
@JackAKirk
Copy link
Author

JackAKirk commented Apr 26, 2022

This PR includes a small patch adding marray coverage to the following not yet merged PR #895

@JackAKirk
Copy link
Author

JackAKirk commented Apr 27, 2022

/verify with intel/llvm#6038

steffenlarsen
steffenlarsen reviewed Apr 28, 2022
View reviewed changes
Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. The tests look good.

@JackAKirk
tests for vec/marray math
f95793b 
sycl::math, native and half_precision cases covered.

Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
@JackAKirk JackAKirk force-pushed the math_marray_tests branch from b77b376 to f95793b Compare May 9, 2022 12:58
JackAKirk added 2 commits May 11, 2022 14:11
@JackAKirk
Made template function improvement.
c7e2ff8 
Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
@JackAKirk
format
b589c32 
Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
@JackAKirk
Copy link
Author

JackAKirk commented May 11, 2022

/verify with intel/llvm#6038

@pvchupin pvchupin requested a review from steffenlarsen June 7, 2022 23:47
@JackAKirk JackAKirk mentioned this pull request Jun 8, 2022
Merged
steffenlarsen
steffenlarsen reviewed Jun 15, 2022
View reviewed changes
JackAKirk added 4 commits June 16, 2022 09:04
@JackAKirk
split fp16 cases into new files.
ab479c8 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
fixed queue constructor mistake.
9e2394e 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
format
80e6994 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
use fp16 aspect in half_builtins.cpp
1f0edf8 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
steffenlarsen
steffenlarsen previously approved these changes Jun 16, 2022
View reviewed changes
Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JackAKirk
removed unnecessary -fsycl-device-code-split=per_kernel.
499c642 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@steffenlarsen
Copy link

steffenlarsen commented Jun 16, 2022

/verify with intel/llvm#6038

steffenlarsen
steffenlarsen previously approved these changes Jun 16, 2022
View reviewed changes
JackAKirk added 3 commits June 23, 2022 11:43
@JackAKirk
Merge branch 'intel' into math_marray_tests
86176da
@JackAKirk
write -> read (superficial change in context of test).
3d03969 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Removed float3 powr tests.
538c64b 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Copy link
Author

JackAKirk commented Sep 6, 2022

/verify with intel/llvm#6038

@JackAKirk
Copy link
Author

JackAKirk commented Sep 6, 2022

/verify with intel/llvm#6038

@JackAKirk
Removed unused cases.
c1972f0 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Merge branch 'math_marray_tests' of https://github.com/JackAKirk/llvm…
68e768d 
…-test-suite into math_marray_tests
@JackAKirk
Copy link
Author

JackAKirk commented Sep 7, 2022

/verify with intel/llvm#6038

@JackAKirk
Add marray -fast-math test cases.
57f3329 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Removed initially proposed native and half_prec tests.
a9efc86 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Added back device-code-split.
f731c93 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Copy link
Author

JackAKirk commented Sep 13, 2022

/verify with intel/llvm#6038

@JackAKirk
Remove host_runs.
505064c 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Copy link
Author

JackAKirk commented Sep 14, 2022

/verify with intel/llvm#6038

4 similar comments
@JackAKirk
Copy link
Author

JackAKirk commented Sep 14, 2022

/verify with intel/llvm#6038

@JackAKirk
Copy link
Author

JackAKirk commented Sep 16, 2022

/verify with intel/llvm#6038

@JackAKirk
Copy link
Author

JackAKirk commented Sep 21, 2022

/verify with intel/llvm#6038

@JackAKirk
Copy link
Author

JackAKirk commented Sep 21, 2022

/verify with intel/llvm#6038

windows && level_zero marked unsupported.
cfc1e91 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Copy link
Author

JackAKirk commented Sep 22, 2022

/verify with intel/llvm#6038

Mark opencl && windows unsupported.
ea6693d 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Copy link
Author

JackAKirk commented Oct 11, 2022

/verify with intel/llvm#6038

1 similar comment
@JackAKirk
Copy link
Author

JackAKirk commented Oct 18, 2022

/verify with intel/llvm#6038

@JackAKirk
Copy link
Author

JackAKirk commented Dec 2, 2022

/verify with intel/llvm#6038

Added fp64 aspect check.
512a37a 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
bader pushed a commit to intel/llvm that referenced this pull request Dec 2, 2022
@JackAKirk
[SYCL] Fix marray math function impls (#6038)
73a992b 
This PR aims to fix issue: #5991
and provide efficient working marray math function implementations for
all backends.

marray math function support is currently switched on for {n} ({n}
defined in #5991) but the implementations are currently broken and
untested. There is also very limited test coverage for sycl::vec cases.
The SYCL 2020 specification states that the set {N} ({N} defined in
#5991) should be supported for marray math function cases.

All SYCL 2020 math, native math, and half_precision math functions now
have marray support when the function's arguments are of type `genfloat`
and have the same argument type for all arguments.

Tests: intel/llvm-test-suite#1002

Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
Co-authored-by: JackAKirk <chezjakirk@gmail.com>
Co-authored-by: Jakub Chlanda <jakub@codeplay.com>
@bader bader merged commit c873dbc into intel:intel Dec 2, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@JackAKirk @bb-sycl
[SYCL] Tests for vec/marray math (intel#1002)
3c28259 
Tests for marray/vec SYCL math functions from: intel/llvm#6038

Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@JackAKirk
[SYCL] Tests for vec/marray math (intel/llvm-test-suite#1002)
9d505d3 
Tests for marray/vec SYCL math functions from: intel#6038

Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JackAKirk @steffenlarsen @bader