This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add tests for marray support in common and some math functions#1656
Open
dm-vodopyanov wants to merge 4 commits intointel:intelfrom
Open
[SYCL] Add tests for marray support in common and some math functions#1656dm-vodopyanov wants to merge 4 commits intointel:intelfrom
dm-vodopyanov wants to merge 4 commits intointel:intelfrom
Conversation
Author
|
/verify with intel/llvm#8631 |
Author
|
/verify with intel/llvm#8631 |
|
/verify with intel/llvm#8631 |
| sycl::marray<float, 3> ma5{180, -180, -180}; | ||
|
|
||
| TEST(sycl::fabs, float, 3, EXPECTED(float, 180, 180, 180), 0, ma5); | ||
| TEST2(sycl::ilogb, float, 3, EXPECTED(int, 7, 7, 7), 0, ma3); |
There was a problem hiding this comment.
Unless I'm missing something, this seems simpler:
Suggested change
| TEST2(sycl::ilogb, float, 3, EXPECTED(int, 7, 7, 7), 0, ma3); | |
| TEST(sycl::ilogb, int, 3, EXPECTED(int, 7, 7, 7), 0, ma3); |
Then we can remove TEST2. Alternatively TEST2 could be defined using TEST to avoid code duplication.
Author
There was a problem hiding this comment.
ilogb takes floats and returns ints, so this is not the usual case where function takes T type and returns T type, so we can't do this change. However, TEST2 can be merged to TEST by adding one new argument to the TEST - the type of return value
AlexeySachkov
pushed a commit
to intel/llvm
that referenced
this pull request
Mar 21, 2023
This patch adds marray support to all functions from Table 179 of SYCL 2020 spec + to functions fabs, ilogb, fmax, fmin, ldexp, pown, rootn from Table 175 + to function exp10 from Table 177. E2E tests: intel/llvm-test-suite#1656 --------- Co-authored-by: KornevNikita <nikita.kornev@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impl: intel/llvm#8631