[SYCL][DOC] Expand complex extension with complex support for sycl::marray#11792
Merged
dm-vodopyanov merged 5 commits intointel:syclfrom Feb 7, 2024
Merged
Conversation
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
Just a couple comments, but otherwise it looks good to me.
sycl/doc/extensions/experimental/sycl_ext_oneapi_complex.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_complex.asciidoc
Outdated
Show resolved
Hide resolved
jle-quel
force-pushed
the
jle-quel/extend-complex-experimental-extension
branch
from
3e8c2b4 to
7b498bb
Compare
jle-quel
force-pushed
the
jle-quel/extend-complex-experimental-extension
branch
from
7b498bb to
261c638
Compare
Contributor
Author
|
@steffenlarsen @gmlueck |
Contributor
Author
|
Do you have any feedback that could postpone the merge of this extension @gmlueck? |
Pennycook
requested changes
Jan 23, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_complex.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_complex.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_complex.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_complex.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_complex.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_complex.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_complex.asciidoc
Outdated
Show resolved
Hide resolved
Pennycook
approved these changes
Jan 31, 2024
Contributor
Author
|
If there are no more blockers, we could be able to move forward with this extension and merge it. What do you people think? |
Contributor
|
Hi @jle-quel, there is a process of merging PRs, PR author can ask @intel/llvm-gatekeepers team to merge it:
https://github.com/intel/llvm/blob/sycl/CONTRIBUTING.md#merge |
This was referenced Feb 7, 2024
sergey-semenov
pushed a commit
that referenced
this pull request
Feb 8, 2024
…12649) This PR apply the modifications asked in the #11792 PR made by @Pennycook --------- Co-authored-by: John Pennycook <john.pennycook@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the updated version of the "complex support for sycl::marray" extension, which used to be a separate extension.
However, after discussing whether it should be a separate extension versus an expansion (#8852), the complex expansion has been decided.
Following the proposal for
sycl::ext::oneapi::experimental::complexwhich adds the support of complex for SYCL, this expansion proposes to incorporate complex support forsycl::marrayand new complex math features.@gmlueck @steffenlarsen
Implementation: #8647