[UR][L0] Release parent of sub-buffer when sub-buffer dies#17489
Merged
steffenlarsen merged 4 commits intointel:syclfrom Mar 26, 2025
Merged
[UR][L0] Release parent of sub-buffer when sub-buffer dies#17489steffenlarsen merged 4 commits intointel:syclfrom
steffenlarsen merged 4 commits intointel:syclfrom
Conversation
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
nrspruit
approved these changes
Mar 17, 2025
Contributor
nrspruit
left a comment
nrspruit
left a comment
There was a problem hiding this comment.
This looks good to me. I think you may be missing a rebase based on the patch due to the windows code gen failure.,
pbalcer
approved these changes
Mar 17, 2025
Contributor
Author
That's odd. It should be based off tip. |
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
Associated change in earlier UR 0.11.x branch: oneapi-src/unified-runtime#2734 |
Contributor
|
The windows error seems unrelated, if this has already been rebased it may be a CI issue. |
igchor
approved these changes
Mar 18, 2025
This commit fixes an issue where the sub-buffer object in the L0 V1 adapter would not release its retained parent, causing leaks. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
nrspruit
force-pushed
the
steffen/release_parent_l0
branch
from
d532e64 to
1a4c29f
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the sub-buffer object in the L0 V1 adapter would not release its retained parent, causing leaks.