[SYCL][HIP] Fix GlobalOffset bad-signature crash and re-enable Assert tests#22677
Open
zjin-lcf wants to merge 3 commits into
Open
[SYCL][HIP] Fix GlobalOffset bad-signature crash and re-enable Assert tests#22677zjin-lcf wants to merge 3 commits into
zjin-lcf wants to merge 3 commits into
Conversation
The GlobalOffsetPass crashed with "Calling a function with a bad signature!" when rewriting callers of functions that gained an implicit global-offset parameter, because non-call uses were handled with an early return and new call instructions were built from the callee's updated type instead of the original call's signature. Iterate over all uses (skipping non-direct-call uses) and construct the new call from the original call's function type with the implicit offset parameter appended. This unblocks assert-in-kernel support on AMD HIP. Re-enables the previously UNSUPPORTED Assert/* e2e tests on HIP. Co-authored-by: Cursor <cursoragent@cursor.com>
This test passes on HIP (gfx942) with the current toolchain, so remove the UNSUPPORTED: hip marker tracked by intel#22300. Co-authored-by: Cursor <cursoragent@cursor.com>
This test was marked UNSUPPORTED on HIP only because device-side assert did not work. assert now works on the HIP backend (GlobalOffset bad-signature crash fix), so remove the stale marker (issue 22300). The test remains UNSUPPORTED on CUDA per the existing fallback-libdevice FIXME. Co-authored-by: Cursor <cursoragent@cursor.com>
cperkinsintel
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GlobalOffsetPasscaused by rebuilding implicit-offset calls with an incorrect call signature, which crashedAsserttests on HIP.Assert/check_resource_leakandDeprecatedFeatures/DiscardEvents/discard_events_using_asserton HIP.Test plan
Assert/assert_in_*pass on gfx942Assert/check_resource_leakpasses on gfx942DiscardEvents/discard_events_using_assertpasses on gfx942Relates to #22300