[SYCL][HIP] Fix crash from SYCL buffer destructors during shutdown#22679
Open
zjin-lcf wants to merge 1 commit into
Open
[SYCL][HIP] Fix crash from SYCL buffer destructors during shutdown#22679zjin-lcf wants to merge 1 commit into
zjin-lcf wants to merge 1 commit into
Conversation
Static SYCL buffer destructors run after the runtime has begun shutting down (their atexit handlers are registered before the runtime's). On HIP this crashed twice: waiting on events whose stream/context was already released segfaults inside libamdhip64, and releasing those events returns hipErrorContextIsDestroyed which was thrown out of the event_impl destructor. - Scheduler::removeMemoryObject: extend the existing Windows-only "skip wait during shutdown" guard to all platforms. Host memory is not written back during shutdown anyway, so the wait serves no purpose and is unsafe against partially torn-down adapters. - HIP adapter event release(): treat hipErrorContextIsDestroyed and hipErrorDeinitialized as a successful release instead of surfacing an exception. Re-enables Regression/static-buffer-dtor.cpp on HIP. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression/static-buffer-dtoron HIP.Test plan
Regression/static-buffer-dtorpasses on gfx942 (repeated runs)Relates to #22300