[SYCL][CUDA] Add bf16 builtins operating on storage types#5748
Merged
bader merged 6 commits intointel:syclfrom Mar 14, 2022
Merged
[SYCL][CUDA] Add bf16 builtins operating on storage types#5748bader merged 6 commits intointel:syclfrom
bader merged 6 commits intointel:syclfrom
Conversation
mlychkov
previously approved these changes
Mar 10, 2022
Contributor
mlychkov
left a comment
There was a problem hiding this comment.
Changes in llvm intrinsics LGTM.
Contributor
Author
|
Which change do you have in mind? There are some test being added to the test suite (linked in PR description). Or do you mean something else needs testing? |
Contributor
@t4c1 , sorry, didn't notice that at first glance. Seem like that'll do. |
Contributor
|
I had to merge with the sycl branch to resolve the conflict with 53a9d54. |
Contributor
Author
|
Thanks. |
Contributor
|
@t4c1, could you fix these warnings, please? |
steffenlarsen
pushed a commit
that referenced
this pull request
Jun 30, 2022
This PR introduces full support of element wise operations in the cuda backend. `wi_data`, `get_matrix_fill`, and `joint_matrix.get_wi_data()` are introduced for portability with the Intel backend. In addition, in the CUDA backend users can call `joint_matrix.wi_marray` to access the marray that stores the WI owned elements of the matrix and perform optimized element wise operations using math functions that take marrays. bfloat16 element wise operations support is also included and this PR adds bfloat16 scalar/marray impls replacing the existing uint16_t "storage type" implementations for fma, fmax, fmin, and fabs math functions. The bfloat16 fma_relu function impl has now been added directly in #5749. The existing temporary uint16_t implementations (introduced in #5748 with unmerged tests intel/llvm-test-suite#897) have been removed, since these bfloat16 implementations replaces them. Signed-off-by: jack.kirk <jack.kirk@codeplay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bf16 builtins operating on storage types. Partially implements https://github.com/intel/llvm/pull/5645/files for CUDA (only operations on storage types).
This PR includes a bugfix for some NVPTX intrinsics, which will also be pushed upstream.
Blocked by #5724.
Tests for this are in intel/llvm-test-suite#897.