[SYCL][Matrix] Add support for tf32 type using the unified interface#8151
Closed
dkhaldi wants to merge 8 commits intointel:syclfrom
Closed
[SYCL][Matrix] Add support for tf32 type using the unified interface#8151dkhaldi wants to merge 8 commits intointel:syclfrom
dkhaldi wants to merge 8 commits intointel:syclfrom
Conversation
Contributor
|
LGTM. Intel backend also does not support tf32 for Accumulator right? btw I think this patch will also allow you to load joint_matrix from |
JackAKirk
reviewed
Jan 30, 2023
| } | ||
| for (int i = 0; i < get_wi_data(sg, sub_b).length(); i++) { | ||
| get_wi_data(sg, sub_b)[i] = | ||
| round_to_tf32(static_cast<float>(get_wi_data(sg, sub_b)[i])); |
Contributor
There was a problem hiding this comment.
is this static_cast<float> required?
Contributor
Author
There was a problem hiding this comment.
No it is not needed I will remove it
dkhaldi
commented
Feb 8, 2023
| // function will work on truncated floats. | ||
| for (int i = 0; i < get_wi_data(sg, sub_a).length(); i++) { | ||
| get_wi_data(sg, sub_a)[i] = | ||
| round_to_tf32(get_wi_data(sg, sub_a)[i]); |
Contributor
Author
There was a problem hiding this comment.
add round_to_tf32 that takes a matrix as an input and returns a matrix as an output. This gives a flexibility to the implementation
MrSidims
reviewed
Feb 10, 2023
Contributor
MrSidims
left a comment
MrSidims
left a comment
There was a problem hiding this comment.
The patch is LGTM
Please hold the merge for a bit to clarify SPIR-V instruction name (Convert Vs Round)
Contributor
Author
|
Replaced with the following: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.