[SYCL] Add tests for atomic_memory_order/scope context queries.#8770
Merged
AlexeySachkov merged 4 commits intointel:syclfrom Apr 6, 2023
Merged
Conversation
Signed-off-by: Maronas, Marcos <marcos.maronas@intel.com>
sycl/source/detail/context_impl.cpp
Outdated
Comment on lines
+203
to
+213
| for (const sycl::device &Device : MDevices) { | ||
| std::vector<sycl::memory_scope> NewCapabilityList; | ||
| std::vector<sycl::memory_scope> DeviceCapabilities = | ||
| Device.get_info<info::device::atomic_memory_scope_capabilities>(); | ||
| std::set_intersection( | ||
| CapabilityList.begin(), CapabilityList.end(), | ||
| DeviceCapabilities.begin(), DeviceCapabilities.end(), | ||
| std::inserter(NewCapabilityList, NewCapabilityList.begin())); | ||
| CapabilityList = NewCapabilityList; | ||
| } | ||
| CapabilityList.shrink_to_fit(); |
Contributor
There was a problem hiding this comment.
Please outline this into a helper and share with line 178.
Contributor
Author
There was a problem hiding this comment.
This was addressed in the latest update.
Signed-off-by: Maronas, Marcos <marcos.maronas@intel.com>
Contributor
Author
|
/testwin |
…_atomic_memory_scope
Contributor
Author
|
Friendly ping @aelovikov-intel @intel/llvm-reviewers-runtime @intel/sycl-language-enabling-triage |
Contributor
|
Hi @maarquitos14, I see only tests changes here. Is that how it's intended? |
Contributor
Author
I just realized the changes in context_impl.cpp were already merged in #8586. I guess I accidentally included the changes there too. Thus, we only have tests in this PR now. I'll update the PR title accordingly. |
maarquitos14
changed the title
atomic_memory_order/scope context queries.
maarquitos14
changed the title
atomic_memory_order/scope context queries.atomic_memory_order/scope context queries.
aelovikov-intel
approved these changes
Apr 4, 2023
…_atomic_memory_scope
Contributor
Author
|
Friendly ping @intel/sycl-language-enabling-triage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for
info::context::atomic_memory_scope_capabilitiesandinfo::context::atomic_memory_order_capabilitiesqueries.