Revert "[SYCL][UR] Link UR PI against UR Loader"#8781
Merged
Conversation
This reverts commit a0d0942.
Contributor
Author
|
/testwin |
Contributor
Author
@bmyates, FYI. Please, investigate these issues and re-apply fixed patch. |
Contributor
@bader Ok I will look into this. Where were these issues observed at? Why were they not detected in pre-merge checks? Just trying to understand the process |
Contributor
Author
We don't have enough resources to run all possible checks in pre-merge checks, so it's possible that some issues can be reported post-merge. Issue 2 is non-deterministic and might be easier to reproduce on specific CI machines. |
Contributor
|
@bmyates : please see here discussion on the issues seen: specifically: |
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
Reverts intel#8637 It caused at least 3 known regressions. 1. intel#8637 (comment) 2. \sycl\plugins\unified_runtime\ur\adapters\level_zero\ur_level_zero_common.hpp(10): fatal error C1083: Cannot open include file: 'sycl/detail/pi.h': No such file or directory 3. ld: error: undefined symbol: pthread_rwlock_wrlock (with GCC 7.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8637
It caused at least 3 known regressions.