[SYCL-MLIR] Opaque pointer support in SYCL-to-LLVM conversion#8944
Merged
sommerlukas merged 11 commits intointel:sycl-mlirfrom Apr 5, 2023
Merged
[SYCL-MLIR] Opaque pointer support in SYCL-to-LLVM conversion#8944sommerlukas merged 11 commits intointel:sycl-mlirfrom
sommerlukas merged 11 commits intointel:sycl-mlirfrom
Conversation
Contributor
Author
etiotto
approved these changes
Apr 4, 2023
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
sommerlukas
force-pushed
the
opaque-pointer-sycl-to-llvm
branch
from
561a574 to
7d6737d
Compare
whitneywhtsang
approved these changes
Apr 5, 2023
victor-eds
suggested changes
Apr 5, 2023
victor-eds
left a comment
victor-eds
left a comment
There was a problem hiding this comment.
For tests with opaque pointers, can we have the full line checked?, i.e., add the missing types after the -> !llvm.ptr in GEPOp, loaded types in LoadOp, etc.
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
victor-eds
approved these changes
Apr 5, 2023
victor-eds
left a comment
victor-eds
left a comment
There was a problem hiding this comment.
Just a single NIT. LGTM if you agree or not.
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
victor-eds
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step to add opaque pointer support for the SYCL-MLIR project: Make the lowering patterns in the SYCL-to-LLVM lowering compatible with opaque pointers.
Emitting typed or opaque pointers is controlled by the
use-opaque-pointerspass option, that was added.Partly resolves #8616.