Skip to content

Fix generation of min/max calls for SYCL #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aneshlya merged 1 commit into from
Jul 11, 2025
Merged

Fix generation of min/max calls for SYCL #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/expr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3033,6 +3033,21 @@ void LibCallExpr::cxxArgPromotion(std::shared_ptr<Expr> &arg,
true);
}

// SYCL 2020 specification defines min and max as accepting two GenInt values.
// GenInt does *not* include bool, so we need to turn it into a char.
void static syclBoolPromotion(std::shared_ptr<Expr> &expr) {
auto expr_type = expr->getValue()->getType();
if (!expr_type->isIntType())
return;

auto expr_int_type = std::static_pointer_cast<IntegralType>(expr_type);
if (expr_int_type->getIntTypeId() != IntTypeID::BOOL)
return;

auto int_type = IntegralType::init(IntTypeID::SCHAR);
expr = std::make_shared<TypeCastExpr>(expr, int_type, false);
}

MinMaxCallBase::MinMaxCallBase(std::shared_ptr<Expr> _a,
std::shared_ptr<Expr> _b, LibCallKind _kind)
: a(std::move(_a)), b(std::move(_b)), kind(_kind) {}
Expand All @@ -3052,6 +3067,11 @@ bool MinMaxCallBase::propagateType() {
ispcBoolPromotion(b);
}

if (options.isSYCL()) {
syclBoolPromotion(a);
syclBoolPromotion(b);
}

IntTypeID top_type_id = getTopIntID({a, b});
cxxArgPromotion(a, top_type_id);
cxxArgPromotion(b, top_type_id);
Expand Down