This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Adding dynamic mode doc and updating ashell doc#1876
Open
brianjjones wants to merge 2 commits intointel:masterfrom
Open
Adding dynamic mode doc and updating ashell doc#1876brianjjones wants to merge 2 commits intointel:masterfrom
brianjjones wants to merge 2 commits intointel:masterfrom
Conversation
Signed-off-by: Brian J Jones <brian.j.jones@intel.com>
grgustaf
suggested changes
Apr 27, 2018
Contributor
grgustaf
left a comment
grgustaf
left a comment
There was a problem hiding this comment.
Fix Travis whitespace error.
Otherwise LGTM apart from doc title stuff...
| @@ -0,0 +1,34 @@ | |||
| Dynamic mode - Adds the ability to run JS from the filesystem | |||
| ============================================================ | |||
Contributor
There was a problem hiding this comment.
Match the equals signs to the text above.
Also, I suggest removing "Adds the ability to" -- titles should be more succinct.
Signed-off-by: Brian J Jones <brian.j.jones@intel.com>
Contributor
Author
|
Updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brian J Jones brian.j.jones@intel.com